linux-kernel - Re: [PATCH] ALSA: cs4236: fix error return comparison of an unsigned integer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hpnhk3uua.wl-tiwai@suse.de>
Date:   Fri, 22 Nov 2019 14:26:53 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     Colin King <colin.king@...onical.com>
Cc:     Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
        <alsa-devel@...a-project.org>, <kernel-janitors@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ALSA: cs4236: fix error return comparison of an unsigned integer

On Fri, 22 Nov 2019 14:13:54 +0100,
Colin King wrote:
> 
> From: Colin Ian King <colin.king@...onical.com>
> 
> The return from pnp_irq is an unsigned integer type resource_size_t
> and hence the error check for a positive non-error code is always
> going to be true.  A check for a non-failure return from pnp_irq
> should in fact be for (resource_size_t)-1 rather than >= 0.
> 
> Addresses-Coverity: ("Unsigned compared against 0")
> Fixes: a9824c868a2c ("[ALSA] Add CS4232 PnP BIOS support")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Applied, thanks.


Takashi