linux-kernel - Re: [PATCH -next] staging: hp100: Fix build error without ETHERNET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c0b78573-48d4-d33e-8684-5a3c4d5e81a9@infradead.org>
Date:   Fri, 22 Nov 2019 08:09:17 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     YueHaibing <yuehaibing@...wei.com>, gregkh@...uxfoundation.org,
        perex@...ex.cz, davem@...emloft.net, joe@...ches.com,
        tglx@...utronix.de
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] staging: hp100: Fix build error without ETHERNET

On 11/12/19 6:13 PM, YueHaibing wrote:
> It should depends on ETHERNET, otherwise building fails:
> 
> drivers/staging/hp/hp100.o: In function `hp100_pci_remove':
> hp100.c:(.text+0x165): undefined reference to `unregister_netdev'
> hp100.c:(.text+0x214): undefined reference to `free_netdev'
> 
> Fixes: 52340b82cf1a ("hp100: Move 100BaseVG AnyLAN driver to staging")
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Acked-by: Randy Dunlap <rdunlap@...radead.org> # build-tested

Thanks.

> ---
>  drivers/staging/hp/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/hp/Kconfig b/drivers/staging/hp/Kconfig
> index fb395cf..f20ab21 100644
> --- a/drivers/staging/hp/Kconfig
> +++ b/drivers/staging/hp/Kconfig
> @@ -6,6 +6,7 @@
>  config NET_VENDOR_HP
>  	bool "HP devices"
>  	default y
> +	depends on ETHERNET
>  	depends on ISA || EISA || PCI
>  	---help---
>  	  If you have a network (Ethernet) card belonging to this class, say Y.
> 


-- 
~Randy