linux-kernel - Re: [PATCH] mdio_bus: revert inadvertent error code change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191122.093135.32405983321803856.davem@davemloft.net>
Date:   Fri, 22 Nov 2019 09:31:35 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     helmut.grohne@...enta.de
Cc:     yuehaibing@...wei.com, andrew@...n.ch, f.fainelli@...il.com,
        hkallweit1@...il.com, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH] mdio_bus: revert inadvertent error code change

From: Helmut Grohne <helmut.grohne@...enta.de>
Date: Fri, 22 Nov 2019 10:17:13 +0100

> The fixed commit inadvertently changes the error code from ENOTSUPP to
> ENOSYS. Doing so breaks (among other things) probing of macb, which
> returns -ENOTSUPP as it is now returned from mdiobus_register_reset.
> 
> Fixes: 1d4639567d97 ("mdio_bus: Fix PTR_ERR applied after initialization to constant")
> Signed-off-by: Helmut Grohne <helmut.grohne@...enta.de>

You should always generate networking bug fixes against the networking
GIT tree, which had you done you would have seen that this bug is
fixed there already.

Thank you.