linux-kernel - Re: [PATCH] net: dsa: ocelot: fix "should it be static?" warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191122.100952.137407515946118851.davem@davemloft.net>
Date:   Fri, 22 Nov 2019 10:09:52 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     chenwandun@...wei.com
Cc:     vladimir.oltean@....com, claudiu.manoil@....com, andrew@...n.ch,
        vivien.didelot@...il.com, f.fainelli@...il.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: dsa: ocelot: fix "should it be static?" warnings

From: Chen Wandun <chenwandun@...wei.com>
Date: Fri, 22 Nov 2019 20:32:45 +0800

> Fix following sparse warnings:
> drivers/net/dsa/ocelot/felix.c:351:6: warning: symbol 'felix_txtstamp' was not declared. Should it be static?
> 
> Signed-off-by: Chen Wandun <chenwandun@...wei.com>

Next time please indicate _explicitly_ which tree your patch is targetting,
because especially in this case the change is only relevant for "net-next"

Also, please provide a proper Fixes: tag.