linux-kernel - Re: [PATCH 2/2] ALSA: aloop: Avoid unexpected timer event callback tasklets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5himnb22z5.wl-tiwai@suse.de>
Date:   Fri, 22 Nov 2019 19:14:06 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     Andrew Gabbasov <andrew_gabbasov@...tor.com>
Cc:     <alsa-devel@...a-project.org>, <linux-kernel@...r.kernel.org>,
        "Jaroslav Kysela" <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
        Timo Wischer <twischer@...adit-jv.com>
Subject: Re: [PATCH 2/2] ALSA: aloop: Avoid unexpected timer event callback tasklets

On Fri, 22 Nov 2019 18:52:18 +0100,
Andrew Gabbasov wrote:
> 
> loopback_snd_timer_close_cable() function waits until all
> scheduled tasklets are completed, but the timer is closed after that
> and can generate more event callbacks, scheduling new tasklets,
> that will not be synchronized with cable closing.
> Move tasklet_kill() call to be executed after snd_timer_close()
> call to avoid such case.
> 
> Fixes: 26c53379f98d ("ALSA: aloop: Support selection of snd_timer instead of jiffies")
> Signed-off-by: Andrew Gabbasov <andrew_gabbasov@...tor.com>

Applied, thanks.


Takashi