linux-kernel - Re: [PATCH v4 0/2] tps6105x add devicetree and leds support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <957d06d2-90d6-6a19-87ab-9cce7d03543d@gmail.com>
Date:   Fri, 22 Nov 2019 22:04:58 +0100
From:   Jacek Anaszewski <jacek.anaszewski@...il.com>
To:     Sven Van Asbroeck <thesven73@...il.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-leds@...r.kernel.org
Subject: Re: [PATCH v4 0/2] tps6105x add devicetree and leds support

On 11/22/19 2:36 PM, Sven Van Asbroeck wrote:
> On Thu, Nov 21, 2019 at 1:20 PM Jacek Anaszewski
> <jacek.anaszewski@...il.com> wrote:
>>
>> For both patches:
>>
>> Acked-by: Jacek Anaszewski <jacek.anaszewski@...il.com>
> 
> Thank you Jacek. To get accepted in a maintainer tree, does this
> patch need more acks/reviews?

It should get ack from Pavel Machek since he now maintains LED tree.

I'd say that it should be merged in one batch with the related change
to the MFD driver, but this is to be agreed upon by Pavel and Lee, via
which tree it will go.

> Should I continue to include it in new patch set versions if it doesn't
> change?

You can include it, and add my ack.

However, you could remove also below lines, since you switched
to using color DT property and a new LED registration API:

-	init_data.devicename = "tps6105x";
-	init_data.default_label = ":torch";

-- 
Best regards,
Jacek Anaszewski