linux-kernel - Re: [PATCH] dt-bindings: mmc: Correct the type of the clk phase properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDyKFokY52H4WO7TZHqfUu46U85dOV6FMp1QeY_ivUpfgS2sw@mail.gmail.com>
Date:   Fri, 22 Nov 2019 08:44:36 +0100
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Manish Narani <manish.narani@...inx.com>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        DTML <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        git@...inx.com
Subject: Re: [PATCH] dt-bindings: mmc: Correct the type of the clk phase properties

On Fri, 22 Nov 2019 at 08:16, Manish Narani <manish.narani@...inx.com> wrote:
>
> The clock phase properties are having two uint32 values. The minItems
> and maxItems are set to 2 for the same. So the property type should be
> 'uint32-array' and not 'uint32'. Modify it to correct the same.
>
> Reported-by: Rob Herring <robh@...nel.org>
> Signed-off-by: Manish Narani <manish.narani@...inx.com>

Applied for next, thanks!

Kind regards
Uffe

> ---
>  .../devicetree/bindings/mmc/mmc-controller.yaml | 17 +++++++++--------
>  1 file changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> index 305b2016bc17..b130450c3b34 100644
> --- a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> +++ b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> @@ -334,16 +334,17 @@ patternProperties:
>        - reg
>
>    "^clk-phase-(legacy|sd-hs|mmc-(hs|hs[24]00|ddr52)|uhs-(sdr(12|25|50|104)|ddr50))$":
> +    allOf:
> +      - $ref: /schemas/types.yaml#/definitions/uint32-array
>      minItems: 2
>      maxItems: 2
> -    allOf:
> -      - $ref: /schemas/types.yaml#/definitions/uint32
> -      - minimum: 0
> -        maximum: 359
> -    description:
> -      Set the clock (phase) delays which are to be configured in the
> -      controller while switching to particular speed mode. These values
> -      are in pair of degrees.
> +    items:
> +      minimum: 0
> +      maximum: 359
> +      description:
> +        Set the clock (phase) delays which are to be configured in the
> +        controller while switching to particular speed mode. These values
> +        are in pair of degrees.
>
>  dependencies:
>    cd-debounce-delay-ms: [ cd-gpios ]
> --
> 2.17.1
>