linux-kernel - Re: [PATCH] platform/chrome: cros_ec: Rename cros_ec_dev to cros_ec_mfd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191122075804.GB3296@dell>
Date:   Fri, 22 Nov 2019 07:58:04 +0000
From:   Lee Jones <lee.jones@...aro.org>
To:     Raul E Rangel <rrangel@...omium.org>
Cc:     enric.balletbo@...labora.com,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        linux-iio@...r.kernel.org,
        Fabien Lahoudere <fabien.lahoudere@...labora.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        linux-i2c@...r.kernel.org, Enrico Granata <egranata@...omium.org>,
        linux-rtc@...r.kernel.org, Chanwoo Choi <cw00.choi@...sung.com>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Benson Leung <bleung@...omium.org>,
        "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        Sebastian Reichel <sre@...nel.org>,
        Douglas Anderson <dianders@...omium.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Jonathan Cameron <jic23@...nel.org>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        linux-media@...r.kernel.org, linux-pm@...r.kernel.org,
        Wolfram Sang <wsa@...-dreams.de>,
        Hartmut Knaack <knaack.h@....de>,
        Alexandru M Stan <amstan@...omium.org>,
        Gwendal Grignou <gwendal@...omium.org>,
        Akshu Agrawal <akshu.agrawal@....com>,
        Guenter Roeck <groeck@...omium.org>,
        linux-kernel@...r.kernel.org,
        Neil Armstrong <narmstrong@...libre.com>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Hans Verkuil <hverkuil-cisco@...all.nl>
Subject: Re: [PATCH] platform/chrome: cros_ec: Rename cros_ec_dev to
 cros_ec_mfd_dev

On Thu, 21 Nov 2019, Raul E Rangel wrote:

> It's very confusing having cros_ec_dev and cros_ec_device. This makes it
> clear you are dealing with the mfd device.

An MFD isn't really a thing. It's a Linuxisum that doesn't really
describe anything meaningful. IMHO it would make more sense to follow
the same hierarchical structure that platform devices use:

  s/cros_ec_mfd_dev/cros_ec_parent/

> Signed-off-by: Raul E Rangel <rrangel@...omium.org>
> ---
> This is based on top of the i2c acpi tunnel patches:
> https://lore.kernel.org/patchwork/project/lkml/list/?series=419791
> 
>  drivers/i2c/busses/i2c-cros-ec-tunnel.c       |  2 +-
>  drivers/iio/accel/cros_ec_accel_legacy.c      |  2 +-
>  .../common/cros_ec_sensors/cros_ec_sensors.c  |  2 +-
>  .../cros_ec_sensors/cros_ec_sensors_core.c    |  2 +-
>  .../cros_ec_sensors/cros_ec_sensors_ring.c    |  2 +-
>  drivers/iio/light/cros_ec_light_prox.c        |  2 +-
>  drivers/iio/pressure/cros_ec_baro.c           |  2 +-
>  .../media/platform/cros-ec-cec/cros-ec-cec.c  |  2 +-
>  drivers/mfd/cros_ec_dev.c                     | 14 ++++-----
>  drivers/platform/chrome/cros_ec_chardev.c     | 21 +++++++-------
>  drivers/platform/chrome/cros_ec_debugfs.c     | 16 +++++-----
>  drivers/platform/chrome/cros_ec_lightbar.c    | 29 ++++++++++---------
>  drivers/platform/chrome/cros_ec_pd_sysfs.c    |  6 ++--
>  drivers/platform/chrome/cros_ec_pd_update.c   | 20 ++++++-------
>  drivers/platform/chrome/cros_ec_sysfs.c       | 16 +++++-----
>  drivers/platform/chrome/cros_ec_vbc.c         |  8 ++---
>  drivers/platform/chrome/cros_usbpd_logger.c   |  6 ++--
>  drivers/power/supply/cros_usbpd-charger.c     |  6 ++--
>  drivers/rtc/rtc-cros-ec.c                     |  2 +-
>  include/linux/mfd/cros_ec.h                   |  8 ++---
>  .../linux/platform_data/cros_ec_pd_update.h   |  4 +--
>  21 files changed, 87 insertions(+), 85 deletions(-)

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog