linux-kernel - RE: [PATCH v4 04/13] exfat: add directory operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <00a001d5a10d$da529670$8ef7c350$@samsung.com>
Date:   Fri, 22 Nov 2019 17:21:34 +0900
From:   "Namjae Jeon" <namjae.jeon@...sung.com>
To:     "'Markus Elfring'" <Markus.Elfring@....de>
Cc:     <linux-kernel@...r.kernel.org>, <kernel-janitors@...r.kernel.org>,
        "'Christoph Hellwig'" <hch@....de>,
        "'Daniel Wagner'" <dwagner@...e.de>,
        "'Greg Kroah-Hartman'" <gregkh@...uxfoundation.org>,
        "'Nikolay Borisov'" <nborisov@...e.com>,
        "'Sungjong Seo'" <sj1557.seo@...sung.com>,
        'Valdis Klētnieks' <valdis.kletnieks@...edu>,
        <linkinjeon@...il.com>, <linux-fsdevel@...r.kernel.org>
Subject: RE: [PATCH v4 04/13] exfat: add directory operations


> >> …
> >>> +++ b/fs/exfat/dir.c
> >> …
> >>> +static int exfat_readdir(struct inode *inode, struct exfat_dir_entry
> >> *dir_entry)
> >>> +{
> >> …
> >>> +			if (!ep) {
> >>> +				ret = -EIO;
> >>> +				goto free_clu;
> >>> +			}
> >>
> >> How do you think about to move a bit of common exception handling code
> >> (at similar places)?
> > Not sure it is good.
> 
> The software development opinions can vary also for this change pattern
> according to different design goals.
> Is such a transformation just another possibility to reduce duplicate
> source code a bit?
I changed it without unnecessary goto abuse. Look at the next version later.
Thanks!
> 
> Regards,
> Markus