lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 21 Nov 2019 18:54:02 -0800 From: John Hubbard <jhubbard@...dia.com> To: Jan Kara <jack@...e.cz> CC: Christoph Hellwig <hch@....de>, Andrew Morton <akpm@...ux-foundation.org>, Al Viro <viro@...iv.linux.org.uk>, Alex Williamson <alex.williamson@...hat.com>, Benjamin Herrenschmidt <benh@...nel.crashing.org>, Björn Töpel <bjorn.topel@...el.com>, Christoph Hellwig <hch@...radead.org>, Dan Williams <dan.j.williams@...el.com>, Daniel Vetter <daniel@...ll.ch>, Dave Chinner <david@...morbit.com>, David Airlie <airlied@...ux.ie>, "David S . Miller" <davem@...emloft.net>, Ira Weiny <ira.weiny@...el.com>, Jason Gunthorpe <jgg@...pe.ca>, Jens Axboe <axboe@...nel.dk>, Jonathan Corbet <corbet@....net>, Jérôme Glisse <jglisse@...hat.com>, Magnus Karlsson <magnus.karlsson@...el.com>, Mauro Carvalho Chehab <mchehab@...nel.org>, Michael Ellerman <mpe@...erman.id.au>, Michal Hocko <mhocko@...e.com>, Mike Kravetz <mike.kravetz@...cle.com>, Paul Mackerras <paulus@...ba.org>, Shuah Khan <shuah@...nel.org>, Vlastimil Babka <vbabka@...e.cz>, <bpf@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>, <kvm@...r.kernel.org>, <linux-block@...r.kernel.org>, <linux-doc@...r.kernel.org>, <linux-fsdevel@...r.kernel.org>, <linux-kselftest@...r.kernel.org>, <linux-media@...r.kernel.org>, <linux-rdma@...r.kernel.org>, <linuxppc-dev@...ts.ozlabs.org>, <netdev@...r.kernel.org>, <linux-mm@...ck.org>, LKML <linux-kernel@...r.kernel.org>, "Aneesh Kumar K . V" <aneesh.kumar@...ux.ibm.com> Subject: Re: [PATCH v7 02/24] mm/gup: factor out duplicate code from four routines On 11/21/19 1:54 AM, Jan Kara wrote: > On Thu 21-11-19 00:29:59, John Hubbard wrote: >>> >>> Otherwise this looks fine and might be a worthwhile cleanup to feed >>> Andrew for 5.5 independent of the gut of the changes. >>> >>> Reviewed-by: Christoph Hellwig <hch@....de> >>> >> >> Thanks for the reviews! Say, it sounds like your view here is that this >> series should be targeted at 5.6 (not 5.5), is that what you have in mind? >> And get the preparatory patches (1-9, and maybe even 10-16) into 5.5? > > One more note :) If you are going to push pin_user_pages() interfaces > (which I'm fine with), it would probably make sense to push also the > put_user_pages() -> unpin_user_pages() renaming so that that inconsistency > in naming does not exist in the released upstream kernel. > > Honza Yes, that's what this patch series does. But I'm not sure if "push" here means, "push out: defer to 5.6", "push (now) into 5.5", or "advocate for"? I will note that it's not going to be easy to rename in one step, now that this is being split up. Because various put_user_pages()-based items are going into 5.5 via different maintainer trees now. Probably I'd need to introduce unpin_user_page() alongside put_user_page()...thoughts? thanks, -- John Hubbard NVIDIA
Powered by blists - more mailing lists