linux-kernel - Re: [PATCH] qed: remove redundant assignments to rc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191122164041.1819414b@cakuba.netronome.com>
Date:   Fri, 22 Nov 2019 16:40:41 -0800
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Colin King <colin.king@...onical.com>
Cc:     Ariel Elior <aelior@...vell.com>, GR-everest-linux-l2@...vell.com,
        "David S . Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] qed: remove redundant assignments to rc

On Fri, 22 Nov 2019 23:38:39 +0000, Colin King wrote:
> diff --git a/drivers/net/ethernet/qlogic/qed/qed_sp_commands.c b/drivers/net/ethernet/qlogic/qed/qed_sp_commands.c
> index 7e0b795230b2..12fc5f3b5cb4 100644
> --- a/drivers/net/ethernet/qlogic/qed/qed_sp_commands.c
> +++ b/drivers/net/ethernet/qlogic/qed/qed_sp_commands.c
> @@ -331,7 +331,7 @@ int qed_sp_pf_start(struct qed_hwfn *p_hwfn,
>  	u8 sb_index = p_hwfn->p_eq->eq_sb_index;
>  	struct qed_spq_entry *p_ent = NULL;
>  	struct qed_sp_init_data init_data;
> -	int rc = -EINVAL;
> +	int rc;
>  	u8 page_cnt, i;
>  
>  	/* update initial eq producer */

I like the clean up but, the variables here are ordered longest 
to shortest, please don't break people's coding style :(