linux-kernel - [PATCH] exfat: fix boolreturn.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191123155221.gkukcyakvvfdghcj@4978f4969bb8>
Date:   Sat, 23 Nov 2019 23:52:21 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Namjae Jeon <namjae.jeon@...sung.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        linux-fsdevel@...r.kernel.org, gregkh@...uxfoundation.org,
        valdis.kletnieks@...edu, hch@....de, linkinjeon@...il.com,
        Markus.Elfring@....de, sj1557.seo@...sung.com, dwagner@...e.de,
        nborisov@...e.com, Namjae Jeon <namjae.jeon@...sung.com>
Subject: [PATCH] exfat: fix boolreturn.cocci warnings

From: kbuild test robot <lkp@...el.com>

fs/exfat/file.c:50:10-11: WARNING: return of 0/1 in function 'exfat_allow_set_time' with return type bool

 Return statements in functions returning bool should use
 true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci

Fixes: f7c468dc756c ("exfat: add exfat in fs/Kconfig and fs/Makefile")
CC: Namjae Jeon <namjae.jeon@...sung.com>
Signed-off-by: kbuild test robot <lkp@...el.com>
---

url:    https://github.com/0day-ci/linux/commits/Namjae-Jeon/add-the-latest-exfat-driver/20191122-084735
base:    9942eae47585ee056b140bbfa306f6a1d6b8f383

 file.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/fs/exfat/file.c
+++ b/fs/exfat/file.c
@@ -47,11 +47,11 @@ static bool exfat_allow_set_time(struct
 		if (in_group_p(inode->i_gid))
 			allow_utime >>= 3;
 		if (allow_utime & MAY_WRITE)
-			return 1;
+			return true;
 	}
 
 	/* use a default check */
-	return 0;
+	return false;
 }
 
 static int exfat_sanitize_mode(const struct exfat_sb_info *sbi,