linux-kernel - Re: [PATCH] Delete obsolete magic constants from documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAANdO=KoAPXh+ZuXOW7XMibvbTchj96vr_aEUtqEDg-H2OVmHw@mail.gmail.com>
Date:   Sat, 23 Nov 2019 16:48:42 +0000
From:   Pascal Terjan <pterjan@...gle.com>
To:     Jonathan Corbet <corbet@....net>
Cc:     Federico Vaga <federico.vaga@...a.pv.it>,
        Harry Wei <harryxiyou@...il.com>, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Delete obsolete magic constants from documentation

On Fri, 22 Nov 2019 at 17:08, Jonathan Corbet <corbet@....net> wrote:
>
> On Thu, 21 Nov 2019 19:15:36 +0000
> Pascal Terjan <pterjan@...gle.com> wrote:
>
> > Those no longer appear in the code.
> > I have some more patches to cleanup some of them from the code but this
> > is an easy first step.
> >
> > Signed-off-by: Pascal Terjan <pterjan@...gle.com>
> > ---
> >  Documentation/process/magic-number.rst        | 44 -------------------
> >  .../it_IT/process/magic-number.rst            | 44 -------------------
> >  .../zh_CN/process/magic-number.rst            | 44 -------------------
> >  3 files changed, 132 deletions(-)
>
> So I absolutely love this patch; we really need to clean this kind of
> cruft out of the docs.
>
> Unfortunately, it doesn't apply to docs-next; did you prepare it against
> linux-next, perhaps?  Is there any chance I could get a version against
> docs-next?

Right, that probably because of the lack of my previous patch
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=fba67e8f897870403e1a4f5fe3835c870cd589e0
which hasn't finished its journey yet

I am not sure how to proceed as there are a few other patches for
various subsystems I am planning to send out (like deleting
RFCOMM_TTY_MAGIC from net/bluetooth/rfcomm/tty.c or GDTIOCTL_MAGIC
from drivers/scsi/gdth_ioctl.h) which will also be touching this file
and I'd rather not cause some merge problems...
Maybe I should not update the documentation in the patches removing
the constants from the code and clean it up separately?

> If you're up for further work on this file, it would be nice to get rid of
> the 2.x "changelog" text at the beginning; I don't think that has any real
> value now.

Sure, I picked this file and initially started cleaning it up,
including deleting that changelog, but then decided to first clean up
the code referencing some of those constants without using them.
There are lots of other things to delete in this file, like references
to OSS and maybe even the file itself given that the practice of using
a magic field in structs is no longer common, but I can start sending
a few simple cleanups.

> Thanks,
>
> jon