linux-kernel - Re: [PATCH v5 0/2] perf: add support for logging debug messages to file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191123040753.nnbstznsabfltwi6@mail.google.com>
Date:   Sat, 23 Nov 2019 04:07:54 +0000
From:   Changbin Du <changbin.du@...il.com>
To:     Namhyung Kim <namhyung@...nel.org>
Cc:     Changbin Du <changbin.du@...il.com>, Jiri Olsa <jolsa@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5 0/2] perf: add support for logging debug messages to
 file

On Tue, Oct 22, 2019 at 12:35:01AM +0900, Namhyung Kim wrote:
> Hello,
> 
> On Fri, Oct 18, 2019 at 9:28 AM Changbin Du <changbin.du@...il.com> wrote:
> >
> > When in TUI mode, it is impossible to show all the debug messages to
> > console. This make it hard to debug perf issues using debug messages.
> > This patch adds support for logging debug messages to file to resolve
> > this problem.
> 
> I thought I implemented a debug message view in TUI mode by saving
> all the messages in a linked list.  But it seems not sent to the list and I
> cannot find it now. :(
> 
Sounds bad :)

> Anyway I understand your concerns and the changes look ok to me, so
> 
> Acked-by: Namhyung Kim <namhyung@...nel.org>
>
Thanks for your review.