linux-kernel - RE: [PATCH] arm64: dts: realtek: Add Realtek rtd1619 and mjolnir

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4235c5641f0f4946beeeea8adfd74970@realtek.com>
Date:   Sat, 23 Nov 2019 08:40:04 +0000
From:   James Tai <james.tai@...ltek.com>
To:     Andreas Färber <afaerber@...e.de>,
        Marc Zyngier <maz@...terjones.org>
CC:     Mark Rutland <mark.rutland@....com>,
        Rob Herring <robh+dt@...nel.org>,
        "'linux-kernel@...r.kernel.org'" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-realtek-soc@...ts.infradead.org" 
        <linux-realtek-soc@...ts.infradead.org>
Subject: RE: [PATCH] arm64: dts: realtek: Add Realtek rtd1619 and mjolnir

Hi Andreas,

> 
> MMIO, for GICD and GICR. It's about fixing the ranges of the /soc node:
> 
> My proposed
> ranges = <0x98000000 0x98000000 0x68000000>; needs to be split, with a gap
> between r-bus and GIC for continued RAM.
> 
> https://github.com/afaerber/linux/commit/1884ec6a533c9d5c2b6ca40ee138ff
> 7e8312b6c8
> 
> This goes back to Rob's review of RTD1295 [1], where we then for lack of
> memory space documentation assumed that everything beyond 2 GiB would
> be potential register space. Here we're dealing with up to 4 GiB though.
> 
> 
> James, are you planning to send a fix-up patch here? If not, you'll need to tell
> me what values to use, e.g., is there a NOR flash region on RTD1619, and does
> RAM continue also in between and after GIC, or is there some timer register
> behind it, like on RTD1195?
> 
> ranges = <0x00000000 0x00000000 0x00030000>, // ??? boot ROM size
>          <0x98000000 0x98000000 0x00200000>, // r-bus
>          // anything here? e.g., NOR flash?
>          <0xff100000 0xff100000 0x00010000>, // GICD
>          <0xff140000 0xff140000 0x000c0000>; // GICR
>          // anything here? e.g., timer enable?
> 
> ranges = <0x00000000 0x00000000 0x00030000>,
>          <0x98000000 0x98000000 0x00200000>,
>          <0xff100000 0xff100000 0x00100000>; // whole GIC?
> 

Yes, I'll send a fix-up patch.


Regards,
James