[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20191124221019.GA1186@rikard>
Date: Sun, 24 Nov 2019 23:10:19 +0100
From: Rikard Falkeborn <rikard.falkeborn@...il.com>
To: Rikard Falkeborn <rikard.falkeborn@...il.com>
Cc: megous@...ous.com, arnd@...db.de, devicetree@...r.kernel.org,
gregkh@...uxfoundation.org, icenowy@...c.io, kishon@...com,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
linux-sunxi@...glegroups.com, mark.rutland@....com,
mripard@...nel.org, paul.kocialkowski@...tlin.com,
robh+dt@...nel.org, tglx@...utronix.de, wens@...e.org
Subject: Re: [PATCH v2] phy: allwinner: Fix GENMASK misuse
On Sun, Nov 10, 2019 at 01:43:55PM +0100, Rikard Falkeborn wrote:
> Arguments are supposed to be ordered high then low.
>
> Fixes: a228890f9458 ("phy: allwinner: add phy driver for USB3 PHY on Allwinner H6 SoC")
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@...il.com>
> Tested-by: Ondrej Jirman <megous@...ous.com>
> ---
> v1->v2: Add fixes tax. Add Ondrejs Tested-by. No functional change.
>
> drivers/phy/allwinner/phy-sun50i-usb3.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/phy/allwinner/phy-sun50i-usb3.c b/drivers/phy/allwinner/phy-sun50i-usb3.c
> index 1169f3e83a6f..b1c04f71a31d 100644
> --- a/drivers/phy/allwinner/phy-sun50i-usb3.c
> +++ b/drivers/phy/allwinner/phy-sun50i-usb3.c
> @@ -49,7 +49,7 @@
> #define SUNXI_LOS_BIAS(n) ((n) << 3)
> #define SUNXI_LOS_BIAS_MASK GENMASK(5, 3)
> #define SUNXI_TXVBOOSTLVL(n) ((n) << 0)
> -#define SUNXI_TXVBOOSTLVL_MASK GENMASK(0, 2)
> +#define SUNXI_TXVBOOSTLVL_MASK GENMASK(2, 0)
>
> struct sun50i_usb3_phy {
> struct phy *phy;
> --
> 2.24.0
>
Ping
Powered by blists - more mailing lists