linux-kernel - Re: [PATCH v3 8/8] MIPS: DTS: jz4780: add sgx gpu node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1574600246.3.0@crapouillou.net>
Date:   Sun, 24 Nov 2019 13:57:26 +0100
From:   Paul Cercueil <paul@...pouillou.net>
To:     "H. Nikolaus Schaller" <hns@...delico.com>
Cc:     David Airlie <airlied@...ux.ie>, Daniel Vetter <daniel@...ll.ch>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Benoît Cousson <bcousson@...libre.com>,
        Tony Lindgren <tony@...mide.com>,
        Ralf Baechle <ralf@...ux-mips.org>,
        Paul Burton <paulburton@...nel.org>,
        James Hogan <jhogan@...nel.org>,
        dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-omap@...r.kernel.org,
        openpvrsgx-devgroup@...ux.org, letux-kernel@...nphoenux.org,
        kernel@...a-handheld.com, linux-mips@...r.kernel.org,
        Paul Boddie <paul@...die.org.uk>
Subject: Re: [PATCH v3 8/8] MIPS: DTS: jz4780: add sgx gpu node

Hi Nikolaus,


Le dim., nov. 24, 2019 at 12:40, H. Nikolaus Schaller 
<hns@...delico.com> a écrit :
> and add interrupt and clocks.
> 
> Tested to build for CI20 board and load a (non-working) driver.
> 
> Suggested-by: Paul Boddie <paul@...die.org.uk>
> Signed-off-by: H. Nikolaus Schaller <hns@...delico.com>
> ---
>  arch/mips/boot/dts/ingenic/jz4780.dtsi | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/arch/mips/boot/dts/ingenic/jz4780.dtsi 
> b/arch/mips/boot/dts/ingenic/jz4780.dtsi
> index c54bd7cfec55..21ea5f4a405b 100644
> --- a/arch/mips/boot/dts/ingenic/jz4780.dtsi
> +++ b/arch/mips/boot/dts/ingenic/jz4780.dtsi
> @@ -46,6 +46,17 @@
>  		#clock-cells = <1>;
>  	};
> 
> +	gpu: gpu@...40000 {

We try to keep the nodes ordered by address, could you move this node 
where it belongs?

Thanks,
-Paul


> +		compatible = "ingenic,jz4780-sgx540-120", "img,sgx540-120", 
> "img,sgx540", "img,sgx5";
> +		reg = <0x13040000 0x4000>;
> +
> +		clocks = <&cgu JZ4780_CLK_GPU>;
> +		clock-names = "gpu";
> +
> +		interrupt-parent = <&intc>;
> +		interrupts = <63>;
> +	};
> +
>  	tcu: timer@...02000 {
>  		compatible = "ingenic,jz4780-tcu",
>  			     "ingenic,jz4770-tcu",
> --
> 2.23.0
>