linux-kernel - Re: [PATCH v26 01/12] Linux Random Number Generator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 25 Nov 2019 07:29:40 +0100
From:   Stephan Mueller <smueller@...onox.de>
To:     kbuild test robot <lkp@...el.com>
Cc:     kbuild-all@...ts.01.org, Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-crypto@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
        linux-api@...r.kernel.org,
        "Eric W. Biederman" <ebiederm@...ssion.com>,
        "Alexander E. Patrakov" <patrakov@...il.com>,
        "Ahmed S. Darwish" <darwish.07@...il.com>,
        "Theodore Y. Ts'o" <tytso@....edu>, Willy Tarreau <w@....eu>,
        Matthew Garrett <mjg59@...f.ucam.org>,
        Vito Caputo <vcaputo@...garu.com>,
        Andreas Dilger <adilger.kernel@...ger.ca>,
        Jan Kara <jack@...e.cz>, Ray Strode <rstrode@...hat.com>,
        William Jon McCann <mccann@....edu>,
        zhangjs <zachary@...shancloud.com>,
        Andy Lutomirski <luto@...nel.org>,
        Florian Weimer <fweimer@...hat.com>,
        Lennart Poettering <mzxreary@...inter.de>,
        Nicolai Stange <nstange@...e.de>,
        "Peter, Matthias" <matthias.peter@....bund.de>,
        Marcelo Henrique Cerri <marcelo.cerri@...onical.com>,
        Roman Drahtmueller <draht@...altsekun.de>,
        Neil Horman <nhorman@...hat.com>,
        Randy Dunlap <rdunlap@...radead.org>
Subject: Re: [PATCH v26 01/12] Linux Random Number Generator

Am Sonntag, 24. November 2019, 23:44:13 CET schrieb kbuild test robot:

Hi kbuild,

> Hi "Stephan,
> 
> Thank you for the patch! Yet something to improve:
> 
> [auto build test ERROR on char-misc/char-misc-testing]
> [also build test ERROR on v5.4-rc8 next-20191122]
> [if your patch is applied to the wrong git tree, please drop us a note to
> help improve the system. BTW, we also suggest to use '--base' option to
> specify the base tree in git format-patch, please see
> https://stackoverflow.com/a/37406982]
> 
> url:   
> https://github.com/0day-ci/linux/commits/Stephan-M-ller/dev-random-a-new-ap
> proach-with-full-SP800-90B/20191125-042152 base:  
> https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
> b78cda795ac83333293f1bfa3165572a47e550c2 config: sh-allmodconfig (attached
> as .config)
> compiler: sh4-linux-gcc (GCC) 7.4.0
> reproduce:
>         wget
> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
> ~/bin/make.cross chmod +x ~/bin/make.cross
>         # save the attached .config to linux build tree
>         GCC_VERSION=7.4.0 make.cross ARCH=sh
> 
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@...el.com>
> 
> All error/warnings (new ones prefixed by >>):
> 
>    In file included from include/linux/printk.h:6:0,
>                     from include/linux/kernel.h:15,
>                     from include/asm-generic/bug.h:19,
>                     from arch/sh/include/asm/bug.h:112,
>                     from include/linux/bug.h:5,
>                     from include/linux/mmdebug.h:5,
>                     from include/linux/percpu.h:5,
>                     from include/asm-generic/irq_regs.h:11,
>                     from ./arch/sh/include/generated/asm/irq_regs.h:1,
> 
>                     from drivers/char/lrng/lrng_pool.c:10:
> >> drivers/char/lrng/lrng_pool.c:216:15: error: initialization from
> >> incompatible pointer type [-Werror=incompatible-pointer-types]

The function prototype needs to return an int - I wonder why that did not show 
in my x86 compile run.

It will be fixed in the next set.

>     core_initcall(lrng_init_time_source);
>                   ^
>    include/linux/init.h:197:50: note: in definition of macro
> '___define_initcall' __attribute__((__section__(#__sec ".init"))) = fn;
>                                                      ^~
>    include/linux/init.h:218:28: note: in expansion of macro
> '__define_initcall' #define core_initcall(fn)  __define_initcall(fn, 1)
>                                ^~~~~~~~~~~~~~~~~
> 
> >> drivers/char/lrng/lrng_pool.c:216:1: note: in expansion of macro
> >> 'core_initcall'
>     core_initcall(lrng_init_time_source);
>     ^~~~~~~~~~~~~
>    cc1: some warnings being treated as errors
> 
> vim +216 drivers/char/lrng/lrng_pool.c
> 
>    215
> 
>  > 216	core_initcall(lrng_init_time_source);
> 
>    217
> 
> ---
> 0-DAY kernel test infrastructure                 Open Source Technology
> Center https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel
> Corporation



Ciao
Stephan