linux-kernel - Re: [PATCH v1 1/2] net: dsa: sja1105: print info about probet chip only after every thing was done.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <caab9bcc-a4a6-db88-aa23-859ffcf6ff85@pengutronix.de>
Date:   Mon, 25 Nov 2019 11:31:55 +0100
From:   Oleksij Rempel <o.rempel@...gutronix.de>
To:     Vladimir Oltean <olteanv@...il.com>
Cc:     mkl@...gutronix.de, Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>, kernel@...gutronix.de,
        netdev <netdev@...r.kernel.org>,
        lkml <linux-kernel@...r.kernel.org>, david@...tonic.nl
Subject: Re: [PATCH v1 1/2] net: dsa: sja1105: print info about probet chip
 only after every thing was done.



On 25.11.19 11:22, Vladimir Oltean wrote:
> On Mon, 25 Nov 2019 at 12:03, Oleksij Rempel <o.rempel@...gutronix.de> wrote:
>>
>> Currently we will get "Probed switch chip" notification multiple times
>> if first probe filed by some reason. To avoid this confusing notifications move
>> dev_info to the end of probe.
>>
>> Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de>
>> ---
> 
> Also there are some typos which should be corrected:
> probet -> probed
> every thing -> everything
> filed -> failed
> 
> "failed for some reason" -> "was deferred"

Ok, thx.

should i resend both patches separately or only this one with spell fixes?

> 
>>   drivers/net/dsa/sja1105/sja1105_main.c | 10 +++++++---
>>   1 file changed, 7 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/net/dsa/sja1105/sja1105_main.c b/drivers/net/dsa/sja1105/sja1105_main.c
>> index 7687ddcae159..1238fd68b2cd 100644
>> --- a/drivers/net/dsa/sja1105/sja1105_main.c
>> +++ b/drivers/net/dsa/sja1105/sja1105_main.c
>> @@ -2191,8 +2191,6 @@ static int sja1105_probe(struct spi_device *spi)
>>                  return rc;
>>          }
>>
>> -       dev_info(dev, "Probed switch chip: %s\n", priv->info->name);
>> -
>>          ds = dsa_switch_alloc(dev, SJA1105_NUM_PORTS);
>>          if (!ds)
>>                  return -ENOMEM;
>> @@ -2218,7 +2216,13 @@ static int sja1105_probe(struct spi_device *spi)
>>
>>          sja1105_tas_setup(ds);
>>
>> -       return dsa_register_switch(priv->ds);
>> +       rc = dsa_register_switch(priv->ds);
>> +       if (rc)
>> +               return rc;
>> +
>> +       dev_info(dev, "Probed switch chip: %s\n", priv->info->name);
>> +
>> +       return 0;
>>   }
>>
>>   static int sja1105_remove(struct spi_device *spi)
>> --
>> 2.24.0
>>
> 
> Thanks,
> -Vladimir
> 

Kind regards,
Oleksij Rempel

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |