linux-kernel - Re: [PATCH v2 2/2] tty: use tty_init_dev_retry() to workaround a race condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <337ba6f4-925d-3636-e18a-ad6d20181329@suse.com>
Date:   Mon, 25 Nov 2019 11:42:50 +0100
From:   Jiri Slaby <jslaby@...e.com>
To:     Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] tty: use tty_init_dev_retry() to workaround a race
 condition

On 24. 11. 19, 1:02, Sudip Mukherjee wrote:
>> BTW do you see the warning from tty_init_dev:
>> "driver does not set tty->port. This will crash the kernel later. Fix
>> the driver!\n"
>> ? Maybe not given console is registered already, but crashes.
> 
> yes. I do see the warning but I have always assumed that the warning is
> because console is openend as soon as it registers and so uart_add_one_port()
> does not get the chance to link it. Is it not so?

Yes it is, I was just curious...

thanks,
-- 
js
suse labs