linux-kernel - [PATCH v2 08/14] parisc: Replace cpu_up/down with device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20191125112754.25223-9-qais.yousef@arm.com>
Date:   Mon, 25 Nov 2019 11:27:48 +0000
From:   Qais Yousef <qais.yousef@....com>
To:     Thomas Gleixner <tglx@...utronix.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Qais Yousef <qais.yousef@....com>,
        "James E.J. Bottomley" <James.Bottomley@...senPartnership.com>,
        Helge Deller <deller@....de>,
        Richard Fontana <rfontana@...hat.com>,
        Armijn Hemel <armijn@...ldur.nl>, linux-parisc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: [PATCH v2 08/14] parisc: Replace cpu_up/down with device_online/offline

The core device API performs extra housekeeping bits that are missing
from directly calling cpu_up/down.

See commit a6717c01ddc2 ("powerpc/rtas: use device model APIs and
serialization during LPM") for an example description of what might go
wrong.

This also prepares to make cpu_up/down a private interface for anything
but the cpu subsystem.

Acked-by: Helge Deller <deller@....de>
Signed-off-by: Qais Yousef <qais.yousef@....com>
CC: "James E.J. Bottomley" <James.Bottomley@...senPartnership.com>
CC: Helge Deller <deller@....de>
CC: Richard Fontana <rfontana@...hat.com>
CC: Armijn Hemel <armijn@...ldur.nl>
CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC: Thomas Gleixner <tglx@...utronix.de>
CC: linux-parisc@...r.kernel.org
CC: linux-kernel@...r.kernel.org
---
 arch/parisc/kernel/processor.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/parisc/kernel/processor.c b/arch/parisc/kernel/processor.c
index 13f771f74ee3..4dde5fe78f0c 100644
--- a/arch/parisc/kernel/processor.c
+++ b/arch/parisc/kernel/processor.c
@@ -212,7 +212,9 @@ static int __init processor_probe(struct parisc_device *dev)
 #ifdef CONFIG_SMP
 	if (cpuid) {
 		set_cpu_present(cpuid, true);
-		cpu_up(cpuid);
+		lock_device_hotplug();
+		device_online(get_cpu_device(cpuid));
+		unlock_device_hotplug();
 	}
 #endif
 
-- 
2.17.1