linux-kernel - Re: [PATCH] random: switch pr_notice with pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 25 Nov 2019 14:40:50 +0200
From:   Ramon Fried <rfried.dev@...il.com>
To:     tytso@....edu, arnd@...db.de, gregkh@...uxfoundation.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] random: switch pr_notice with pr_info

Touching base.

On Tue, Nov 12, 2019 at 9:18 PM Ramon Fried <rfried.dev@...il.com> wrote:
>
> Because there's no need to shout that loud.
> In a lot of systems pr_notice ends up also on the console
> especially in embedded systems, where it just annoying
> to get the "fast init done" just when you type a command
> in the terminal.
>
> Signed-off-by: Ramon Fried <rfried.dev@...il.com>
> ---
>  drivers/char/random.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/char/random.c b/drivers/char/random.c
> index de434feb873a..a619002f96af 100644
> --- a/drivers/char/random.c
> +++ b/drivers/char/random.c
> @@ -885,7 +885,7 @@ static void crng_initialize(struct crng_state *crng)
>                 invalidate_batched_entropy();
>                 numa_crng_init();
>                 crng_init = 2;
> -               pr_notice("random: crng done (trusting CPU's manufacturer)\n");
> +               pr_info("random: crng done (trusting CPU's manufacturer)\n");
>         }
>         crng->init_time = jiffies - CRNG_RESEED_INTERVAL - 1;
>  }
> @@ -948,7 +948,7 @@ static int crng_fast_load(const char *cp, size_t len)
>                 invalidate_batched_entropy();
>                 crng_init = 1;
>                 wake_up_interruptible(&crng_init_wait);
> -               pr_notice("random: fast init done\n");
> +               pr_info("random: fast init done\n");
>         }
>         return 1;
>  }
> @@ -1033,15 +1033,15 @@ static void crng_reseed(struct crng_state *crng, struct entropy_store *r)
>                 crng_init = 2;
>                 process_random_ready_list();
>                 wake_up_interruptible(&crng_init_wait);
> -               pr_notice("random: crng init done\n");
> +               pr_info("random: crng init done\n");
>                 if (unseeded_warning.missed) {
> -                       pr_notice("random: %d get_random_xx warning(s) missed "
> +                       pr_info("random: %d get_random_xx warning(s) missed "
>                                   "due to ratelimiting\n",
>                                   unseeded_warning.missed);
>                         unseeded_warning.missed = 0;
>                 }
>                 if (urandom_warning.missed) {
> -                       pr_notice("random: %d urandom warning(s) missed "
> +                       pr_info("random: %d urandom warning(s) missed "
>                                   "due to ratelimiting\n",
>                                   urandom_warning.missed);
>                         urandom_warning.missed = 0;
> --
> 2.23.0
>