linux-kernel - Re: [PATCH 1/8] add header file for kelvin to/from Celsius conversion helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAC5umyjzDODZf8ECWDmR6SAY-TNkdJ+a0GZRgOFcPCAMok2Ddg@mail.gmail.com>
Date:   Mon, 25 Nov 2019 23:29:56 +0900
From:   Akinobu Mita <akinobu.mita@...il.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Linux NVMe Mailinglist <linux-nvme@...ts.infradead.org>,
        linux-hwmon@...r.kernel.org, Linux PM <linux-pm@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Sujith Thomas <sujith.thomas@...el.com>,
        Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        Zhang Rui <rui.zhang@...el.com>,
        Eduardo Valentin <edubezval@...il.com>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Amit Kucheria <amit.kucheria@...durent.com>,
        Jean Delvare <jdelvare@...e.com>,
        Guenter Roeck <linux@...ck-us.net>,
        Keith Busch <kbusch@...nel.org>, Jens Axboe <axboe@...com>,
        Christoph Hellwig <hch@....de>,
        Sagi Grimberg <sagi@...mberg.me>
Subject: Re: [PATCH 1/8] add header file for kelvin to/from Celsius conversion helpers

2019年11月24日(日) 23:57 Andy Shevchenko <andy.shevchenko@...il.com>:
>
> On Sun, Nov 24, 2019 at 4:09 PM Akinobu Mita <akinobu.mita@...il.com> wrote:
> >
> > There are several helper macros to convert kelvin to/from Celsius in
> > <linux/thermal.h> for thermal drivers.  These are useful for any other
> > drivers or subsystems, but it's odd to include <linux/thermal.h> just for
> > the helpers.
> >
> > This adds a new <linux/temperature.h> that provides the equivalent inline
> > functions for any drivers or subsystems.  It is intended to replace the
> > helpers in <linux/thermal.h>.
> >
> > Cc: Sujith Thomas <sujith.thomas@...el.com>
> > Cc: Darren Hart <dvhart@...radead.org>
> > Cc: Andy Shevchenko <andy@...radead.org>
> > Cc: Zhang Rui <rui.zhang@...el.com>
> > Cc: Eduardo Valentin <edubezval@...il.com>
> > Cc: Daniel Lezcano <daniel.lezcano@...aro.org>
> > Cc: Amit Kucheria <amit.kucheria@...durent.com>
> > Cc: Jean Delvare <jdelvare@...e.com>
> > Cc: Guenter Roeck <linux@...ck-us.net>
> > Cc: Keith Busch <kbusch@...nel.org>
> > Cc: Jens Axboe <axboe@...com>
> > Cc: Christoph Hellwig <hch@....de>
> > Cc: Sagi Grimberg <sagi@...mberg.me>
> > Signed-off-by: Akinobu Mita <akinobu.mita@...il.com>
> > ---
> >  include/linux/temperature.h | 39 +++++++++++++++++++++++++++++++++++++++
>
> >  include/linux/thermal.h     |  1 +
>
>
> > --- a/include/linux/thermal.h
> > +++ b/include/linux/thermal.h
> > @@ -14,6 +14,7 @@
> >  #include <linux/idr.h>
> >  #include <linux/device.h>
> >  #include <linux/sysfs.h>
> > +#include <linux/temperature.h>
> >  #include <linux/workqueue.h>
> >  #include <uapi/linux/thermal.h>
>
> I don't see any users of it. Why did you include?

The rest of this patch series starts using it.

I decided to include <linux/temperature.h> from <linux/thermal.h> because
the existing <linux/thermal.h> provides the conversion helpers.

However, not all of the thermal drivers require these conversion helpers,
so we can change to include <linux/temperature.h> from each thermal driver
instead of including it from <linux/thermal.h>.

Which way do you prefer?