linux-kernel - Re: [BUGFIX PATCH v3 4/4] selftests/ftrace: Fix multiple kprobe testcase

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191125094918.738f2c0c@gandalf.local.home>
Date:   Mon, 25 Nov 2019 09:49:18 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Masami Hiramatsu <mhiramat@...nel.org>
Cc:     Shuah Khan <shuah@...nel.org>, linux-kselftest@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [BUGFIX PATCH v3 4/4] selftests/ftrace: Fix multiple kprobe
 testcase

On Mon, 25 Nov 2019 15:57:27 +0900
Masami Hiramatsu <mhiramat@...nel.org> wrote:

> Fix multiple kprobe event testcase to work it correctly.
> There are 2 bugfixes.
>  - Since `wc -l FILE` returns not only line number but also
>    FILE filename, following "if" statement always failed.
>    Fix this bug by replacing it with 'cat FILE | wc -l'
>  - Since "while do-done loop" block with pipeline becomes a
>    subshell, $N local variable is not update outside of
>    the loop.
>    Fix this bug by using actual target number (256) instead
>    of $N.
> 
> Signed-off-by: Masami Hiramatsu <mhiramat@...nel.org>

Reviewed-by: Steven Rostedt (VMware) <rostedt@...dmis.org>

-- Steve