linux-kernel - Re: [PATCH -next] drm/amd/display: remove set but not used variable 'msg_out'

Open Source and information security mailing list archives

Message-ID: <CADnq5_Ms09to8Pr7BedmTZ37an=bBO+6ghHQQGJZBiefctRMZA@mail.gmail.com>
Date:   Mon, 25 Nov 2019 10:15:07 -0500
From:   Alex Deucher <alexdeucher@...il.com>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     "Wentland, Harry" <harry.wentland@....com>,
        "Leo (Sunpeng) Li" <sunpeng.li@....com>,
        "Deucher, Alexander" <alexander.deucher@....com>,
        Christian Koenig <christian.koenig@....com>,
        Chunming Zhou <David1.Zhou@....com>,
        Dave Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Bhawanpreet Lakha <Bhawanpreet.Lakha@....com>,
        Maling list - DRI developers 
        <dri-devel@...ts.freedesktop.org>,
        amd-gfx list <amd-gfx@...ts.freedesktop.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] drm/amd/display: remove set but not used variable 'msg_out'

On Mon, Nov 25, 2019 at 10:00 AM YueHaibing <yuehaibing@...wei.com> wrote:
>
> drivers/gpu/drm/amd/amdgpu/../display/modules/hdcp/hdcp_psp.c: In function mod_hdcp_hdcp2_enable_encryption:
> drivers/gpu/drm/amd/amdgpu/../display/modules/hdcp/hdcp_psp.c:633:77: warning: variable msg_out set but not used [-Wunused-but-set-variable]
> drivers/gpu/drm/amd/amdgpu/../display/modules/hdcp/hdcp_psp.c: In function mod_hdcp_hdcp2_enable_dp_stream_encryption:
> drivers/gpu/drm/amd/amdgpu/../display/modules/hdcp/hdcp_psp.c:710:77: warning: variable msg_out set but not used [-Wunused-but-set-variable]
>
> It is never used, so remove it.
>
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Applied.  Thanks!

Alex

> ---
>  drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c
> index 2dd5fee..468f5e6 100644
> --- a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c
> +++ b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_psp.c
> @@ -630,14 +630,12 @@ enum mod_hdcp_status mod_hdcp_hdcp2_enable_encryption(struct mod_hdcp *hdcp)
>         struct psp_context *psp = hdcp->config.psp.handle;
>         struct ta_hdcp_shared_memory *hdcp_cmd;
>         struct ta_hdcp_cmd_hdcp2_process_prepare_authentication_message_input_v2 *msg_in;
> -       struct ta_hdcp_cmd_hdcp2_process_prepare_authentication_message_output_v2 *msg_out;
>         struct mod_hdcp_display *display = get_first_added_display(hdcp);
>
>         hdcp_cmd = (struct ta_hdcp_shared_memory *)psp->hdcp_context.hdcp_shared_buf;
>         memset(hdcp_cmd, 0, sizeof(struct ta_hdcp_shared_memory));
>
>         msg_in = &hdcp_cmd->in_msg.hdcp2_prepare_process_authentication_message_v2;
> -       msg_out = &hdcp_cmd->out_msg.hdcp2_prepare_process_authentication_message_v2;
>
>         hdcp2_message_init(hdcp, msg_in);
>
> @@ -707,14 +705,12 @@ enum mod_hdcp_status mod_hdcp_hdcp2_enable_dp_stream_encryption(struct mod_hdcp
>         struct psp_context *psp = hdcp->config.psp.handle;
>         struct ta_hdcp_shared_memory *hdcp_cmd;
>         struct ta_hdcp_cmd_hdcp2_process_prepare_authentication_message_input_v2 *msg_in;
> -       struct ta_hdcp_cmd_hdcp2_process_prepare_authentication_message_output_v2 *msg_out;
>         uint8_t i;
>
>         hdcp_cmd = (struct ta_hdcp_shared_memory *)psp->hdcp_context.hdcp_shared_buf;
>         memset(hdcp_cmd, 0, sizeof(struct ta_hdcp_shared_memory));
>
>         msg_in = &hdcp_cmd->in_msg.hdcp2_prepare_process_authentication_message_v2;
> -       msg_out = &hdcp_cmd->out_msg.hdcp2_prepare_process_authentication_message_v2;
>
>         hdcp2_message_init(hdcp, msg_in);
>
> --
> 2.7.4
>
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives