linux-kernel - Re: [PATCH -next] drm/amd/powerplay: remove set but not used variable 'stretch_amount2'

Open Source and information security mailing list archives

Message-ID: <CADnq5_Mn1vsXzEGA254spvhaAaW+Q4y20orjWBbz2doVCvbYrw@mail.gmail.com>
Date:   Mon, 25 Nov 2019 10:16:37 -0500
From:   Alex Deucher <alexdeucher@...il.com>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     "Quan, Evan" <evan.quan@....com>,
        "Deucher, Alexander" <alexander.deucher@....com>,
        Christian Koenig <christian.koenig@....com>,
        Chunming Zhou <David1.Zhou@....com>,
        Dave Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Prike Liang <Prike.Liang@....com>,
        Chen Wandun <chenwandun@...wei.com>,
        yu kuai <yukuai3@...wei.com>,
        Maling list - DRI developers 
        <dri-devel@...ts.freedesktop.org>,
        amd-gfx list <amd-gfx@...ts.freedesktop.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] drm/amd/powerplay: remove set but not used variable 'stretch_amount2'

On Mon, Nov 25, 2019 at 10:00 AM YueHaibing <yuehaibing@...wei.com> wrote:
>
> drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/vegam_smumgr.c:
>  In function vegam_populate_clock_stretcher_data_table:
> drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/vegam_smumgr.c:1489:29:
>  warning: variable stretch_amount2 set but not used [-Wunused-but-set-variable]
>
> It is never used, so can be removed.
>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Applied.  thanks!

Alex

> ---
>  drivers/gpu/drm/amd/powerplay/smumgr/vegam_smumgr.c | 10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/vegam_smumgr.c b/drivers/gpu/drm/amd/powerplay/smumgr/vegam_smumgr.c
> index 50896e9..b0e0d67 100644
> --- a/drivers/gpu/drm/amd/powerplay/smumgr/vegam_smumgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/smumgr/vegam_smumgr.c
> @@ -1486,7 +1486,7 @@ static int vegam_populate_clock_stretcher_data_table(struct pp_hwmgr *hwmgr)
>         struct vegam_smumgr *smu_data =
>                         (struct vegam_smumgr *)(hwmgr->smu_backend);
>
> -       uint8_t i, stretch_amount, stretch_amount2, volt_offset = 0;
> +       uint8_t i, stretch_amount, volt_offset = 0;
>         struct phm_ppt_v1_information *table_info =
>                         (struct phm_ppt_v1_information *)(hwmgr->pptable);
>         struct phm_ppt_v1_clock_voltage_dependency_table *sclk_table =
> @@ -1525,11 +1525,9 @@ static int vegam_populate_clock_stretcher_data_table(struct pp_hwmgr *hwmgr)
>                         (table_info->cac_dtp_table->ucCKS_LDO_REFSEL != 0) ?
>                         table_info->cac_dtp_table->ucCKS_LDO_REFSEL : 5;
>         /* Populate CKS Lookup Table */
> -       if (stretch_amount == 1 || stretch_amount == 2 || stretch_amount == 5)
> -               stretch_amount2 = 0;
> -       else if (stretch_amount == 3 || stretch_amount == 4)
> -               stretch_amount2 = 1;
> -       else {
> +       if (!(stretch_amount == 1 || stretch_amount == 2 ||
> +             stretch_amount == 5 || stretch_amount == 3 ||
> +             stretch_amount == 4)) {
>                 phm_cap_unset(hwmgr->platform_descriptor.platformCaps,
>                                 PHM_PlatformCaps_ClockStretcher);
>                 PP_ASSERT_WITH_CODE(false,
> --
> 2.7.4
>
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives