linux-kernel - Re: [PATCH 2/3] drivers: net: intel: Fix -Wcast-function-type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <61fa4ef5-e4fc-c20c-9e20-158bcdf61cbb@lwfinger.net>
Date:   Mon, 25 Nov 2019 11:30:47 -0600
From:   Larry Finger <Larry.Finger@...inger.net>
To:     Phong Tran <tranmanphong@...il.com>, jakub.kicinski@...ronome.com,
        kvalo@...eaurora.org, davem@...emloft.net,
        luciano.coelho@...el.com, shahar.s.matityahu@...el.com,
        johannes.berg@...el.com, emmanuel.grumbach@...el.com,
        sara.sharon@...el.com, yhchuang@...ltek.com, yuehaibing@...wei.com,
        pkshih@...ltek.com, arend.vanspriel@...adcom.com, rafal@...ecki.pl,
        franky.lin@...adcom.com, pieter-paul.giesberts@...adcom.com,
        p.figiel@...lintechnologies.com, Wright.Feng@...ress.com,
        keescook@...omium.org
Cc:     linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] drivers: net: intel: Fix -Wcast-function-type

On 11/25/19 9:02 AM, Phong Tran wrote:
> correct usage prototype of callback in tasklet_init().
> Report by https://github.com/KSPP/linux/issues/20
> 
> Signed-off-by: Phong Tran <tranmanphong@...il.com>
> ---
>   drivers/net/wireless/intel/ipw2x00/ipw2100.c   | 7 ++++---
>   drivers/net/wireless/intel/ipw2x00/ipw2200.c   | 5 +++--
>   drivers/net/wireless/intel/iwlegacy/3945-mac.c | 5 +++--
>   drivers/net/wireless/intel/iwlegacy/4965-mac.c | 5 +++--
>   4 files changed, 13 insertions(+), 9 deletions(-)

This patch is "fixing" three different drivers and should be split into at least 
two parts. To be consistent with previous practices, the subject for the two 
should be "intel: ipw2100: ...." and "intel: iwlegacy: ...."

Larry