linux-kernel - Re: [PATCH 3/5] drivers: net: b43legacy: Fix -Wcast-function-type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8eb8d6fd-de20-2d04-8210-ad8304d7da9e@lwfinger.net>
Date:   Mon, 25 Nov 2019 12:30:59 -0600
From:   Larry Finger <Larry.Finger@...inger.net>
To:     Phong Tran <tranmanphong@...il.com>, davem@...emloft.net,
        keescook@...omium.org
Cc:     kvalo@...eaurora.org, saeedm@...lanox.com,
        jeffrey.t.kirsher@...el.com, luciano.coelho@...el.com,
        netdev@...r.kernel.org, linux-wireless@...r.kernel.org,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/5] drivers: net: b43legacy: Fix -Wcast-function-type

On 11/24/19 3:43 AM, Phong Tran wrote:
> correct usage prototype of callback in tasklet_init().
> Report by https://github.com/KSPP/linux/issues/20
> 
> Signed-off-by: Phong Tran <tranmanphong@...il.com>
> ---
>   drivers/net/wireless/broadcom/b43legacy/main.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)

The subject should be "b43legacy: .....". Otherwise it is OK.

Tested-by: Larry Finger <Larry.Finger@...inger.net>

Larry

> 
> diff --git a/drivers/net/wireless/broadcom/b43legacy/main.c b/drivers/net/wireless/broadcom/b43legacy/main.c
> index 4325e91736eb..8b6b657c4b85 100644
> --- a/drivers/net/wireless/broadcom/b43legacy/main.c
> +++ b/drivers/net/wireless/broadcom/b43legacy/main.c
> @@ -1275,8 +1275,9 @@ static void handle_irq_ucode_debug(struct b43legacy_wldev *dev)
>   }
>   
>   /* Interrupt handler bottom-half */
> -static void b43legacy_interrupt_tasklet(struct b43legacy_wldev *dev)
> +static void b43legacy_interrupt_tasklet(unsigned long data)
>   {
> +	struct b43legacy_wldev *dev = (struct b43legacy_wldev *)data;
>   	u32 reason;
>   	u32 dma_reason[ARRAY_SIZE(dev->dma_reason)];
>   	u32 merged_dma_reason = 0;
> @@ -3741,7 +3742,7 @@ static int b43legacy_one_core_attach(struct ssb_device *dev,
>   	b43legacy_set_status(wldev, B43legacy_STAT_UNINIT);
>   	wldev->bad_frames_preempt = modparam_bad_frames_preempt;
>   	tasklet_init(&wldev->isr_tasklet,
> -		     (void (*)(unsigned long))b43legacy_interrupt_tasklet,
> +		     b43legacy_interrupt_tasklet,
>   		     (unsigned long)wldev);
>   	if (modparam_pio)
>   		wldev->__using_pio = true;
>