linux-kernel - RE: [PATCH 1/2] can: xilinx_can: skip error message on deferred probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 25 Nov 2019 03:58:14 +0000
From:   Appana Durga Kedareswara Rao <appanad@...inx.com>
To:     Srinivas Neeli <sneeli@...inx.com>,
        "wg@...ndegger.com" <wg@...ndegger.com>,
        "mkl@...gutronix.de" <mkl@...gutronix.de>,
        "davem@...emloft.net" <davem@...emloft.net>,
        Michal Simek <michals@...inx.com>
CC:     "linux-can@...r.kernel.org" <linux-can@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        git <git@...inx.com>,
        Naga Sureshkumar Relli <nagasure@...inx.com>,
        Venkatesh Yadav Abbarapu <VABBARAP@...inx.com>,
        Srinivas Neeli <sneeli@...inx.com>
Subject: RE: [PATCH 1/2] can: xilinx_can: skip error message on deferred probe

Hi,

> -----Original Message-----
> From: Srinivas Neeli <srinivas.neeli@...inx.com>
> Sent: Wednesday, November 20, 2019 5:41 PM
> To: wg@...ndegger.com; mkl@...gutronix.de; davem@...emloft.net;
> Michal Simek <michals@...inx.com>; Appana Durga Kedareswara Rao
> <appanad@...inx.com>
> Cc: linux-can@...r.kernel.org; netdev@...r.kernel.org; linux-arm-
> kernel@...ts.infradead.org; linux-kernel@...r.kernel.org; git
> <git@...inx.com>; Naga Sureshkumar Relli <nagasure@...inx.com>;
> Venkatesh Yadav Abbarapu <VABBARAP@...inx.com>; Srinivas Neeli
> <sneeli@...inx.com>
> Subject: [PATCH 1/2] can: xilinx_can: skip error message on deferred probe
> 
> From: Venkatesh Yadav Abbarapu <venkatesh.abbarapu@...inx.com>
> 
> When can clock is provided from the clock wizard, clock wizard driver may
> not be available when can driver probes resulting to the error message "bus
> clock not found error".
> 
> As this error message is not very useful to the end user, skip printing in the
> case of deferred probe.
> 
> Signed-off-by: Venkatesh Yadav Abbarapu <venkatesh.abbarapu@...inx.com>
> Signed-off-by: Srinivas Neeli <srinivas.neeli@...inx.com>
> Signed-off-by: Michal Simek <michal.simek@...inx.com>

@Srinivas Neeli: Please send v2 with improved commit message as Marc suggested, feel free to add 
Reviewed-by: Appana Durga Kedareswara Rao <appana.durga.rao@...inx.com> in v2. 

Regards,
Kedar.
> ---
>  drivers/net/can/xilinx_can.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/can/xilinx_can.c b/drivers/net/can/xilinx_can.c index
> 4a96e2dd7d77..c5f05b994435 100644
> --- a/drivers/net/can/xilinx_can.c
> +++ b/drivers/net/can/xilinx_can.c
> @@ -1772,7 +1772,8 @@ static int xcan_probe(struct platform_device
> *pdev)
> 
>  	priv->bus_clk = devm_clk_get(&pdev->dev, devtype->bus_clk_name);
>  	if (IS_ERR(priv->bus_clk)) {
> -		dev_err(&pdev->dev, "bus clock not found\n");
> +		if (PTR_ERR(priv->bus_clk) != -EPROBE_DEFER)
> +			dev_err(&pdev->dev, "bus clock not found\n");
>  		ret = PTR_ERR(priv->bus_clk);
>  		goto err_free;
>  	}
> --
> 2.7.4