linux-kernel - Re: [PATCH] Revert "Input: synaptics - enable RMI mode for X1 Extreme 2nd Generation"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 25 Nov 2019 10:52:11 -0800
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Lyude Paul <lyude@...hat.com>
Cc:     linux-input@...r.kernel.org, stable@...r.kernel.org,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Mantas Mikulėnas <grawity@...il.com>,
        Nick Black <dankamongmen@...il.com>,
        Yussuf Khalil <dev@...345.net>,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        Alexander Mikhaylenko <exalm7659@...il.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Joe Perches <joe@...ches.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Revert "Input: synaptics - enable RMI mode for X1
 Extreme 2nd Generation"

On Tue, Nov 19, 2019 at 06:45:33PM -0500, Lyude Paul wrote:
> This reverts commit 68b9c5066e39af41d3448abfc887c77ce22dd64d.
> 
> Ugh, I really dropped the ball on this one :\. So as it turns out RMI4
> works perfectly fine on the X1 Extreme Gen 2 except for one thing I
> didn't notice because I usually use the trackpoint: clicking with the
> touchpad. Somehow this is broken, in fact we don't even seem to indicate
> BTN_LEFT as a valid event type for the RMI4 touchpad. And, I don't even
> see any RMI4 events coming from the touchpad when I press down on it.
> This only seems to work for PS/2 mode.
> 
> Since that means we have a regression, and PS/2 mode seems to work fine
> for the time being - revert this for now. We'll have to do a more
> thorough investigation on this.
> 
> Signed-off-by: Lyude Paul <lyude@...hat.com>
> Cc: stable@...r.kernel.org

This has been applied, thank you.

-- 
Dmitry