linux-kernel - Re: [BUGFIX PATCH v3 1/4] selftests/ftrace: Fix to check the existence of set_ftrace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191126163132.59a0c9811acdcf62a7431222@kernel.org>
Date:   Tue, 26 Nov 2019 16:31:32 +0900
From:   Masami Hiramatsu <mhiramat@...nel.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Shuah Khan <shuah@...nel.org>, linux-kselftest@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [BUGFIX PATCH v3 1/4] selftests/ftrace: Fix to check the
 existence of set_ftrace_filter

On Mon, 25 Nov 2019 20:54:29 -0500
Steven Rostedt <rostedt@...dmis.org> wrote:

> On Tue, 26 Nov 2019 09:13:45 +0900
> Masami Hiramatsu <mhiramat@...nel.org> wrote:
> 
> > > > @@ -93,7 +96,6 @@ initialize_ftrace() { # Reset ftrace to initial-state
> > > >      disable_events
> > > >      [ -f set_event_pid ] && echo > set_event_pid
> > > >      [ -f set_ftrace_pid ] && echo > set_ftrace_pid
> > > > -    [ -f set_ftrace_filter ] && echo | tee set_ftrace_*  
> > > 
> > > The above should be changed to:
> > > 
> > > 	[ -f set_ftrace_notrace ] && echo > set_ftrace_notrace  
> > 
> > Ah, good point! I think that should be done by another patch, since
> > it will improve ftracetest.
> 
> No, it belongs in this patch, because you are removing:
> 
> 	[ -f set_ftrace_filter ] && echo | tee set_ftrace_*
> 
> which is equivalent to:
> 
> 	[ -f set_ftrace_filter ] && echo > set_ftrace_filter
> 	[ -f set_ftrace_filter ] && echo > set_ftrace_notrace
> 
> as the "tee set_ftrace_*" covers both.

Ah, I see. 

> 
> Without this change, this patch removes the update to
> set_ftrace_notrace.

OK, I'll update it.

Thank you!

> 
> -- Steve


-- 
Masami Hiramatsu <mhiramat@...nel.org>