linux-kernel - RE: [PATCH] usb: gadget: f_ncm: fix wrong usb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <VI1PR04MB53277359AF0E283AE948F34C8B450@VI1PR04MB5327.eurprd04.prod.outlook.com>
Date:   Tue, 26 Nov 2019 07:55:12 +0000
From:   Peter Chen <peter.chen@....com>
To:     Henry Lin <henryl@...dia.com>
CC:     Felipe Balbi <balbi@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Romain Izard <romain.izard.pro@...il.com>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] usb: gadget: f_ncm: fix wrong usb_ep

 
> >Would you please share the use case how to reproduce it?
> We checked again and found NCM gadget driver should not have this issue.
> Please ignore this patch.
> 
> However, we still observe similar issue in ECM and RNDIS gadget driver. Take
> ECM as example, if we plug ECM gadget in high-speed host port first. And, the host
> only set interface with alternate setting != 1 (alt != 1 in ecm_set_alt()) for ECM
> gadget. Then, if we unplug gadget from high-speed host port to another super-
> speed host port afterwards, we will see both in_ep->desc and out_ep->desc in ecm-
> >port keep values for high-speed endpoints. Although NCM's implementation is
> similar to ECM in this part, NCM doesn't have same issue as it only does
> config_ep_by_speed() under if alt is 1.

Does your UDC driver call composite_disconnect when disconnect from the host?
It should set all desc to NULL at related function ->disable.

Peter