linux-kernel - Re: [PATCH] mm: khugepaged: add trace status description for SCAN_PAGE_HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <729623eb-df56-c436-2ca3-8f73772f539c@arm.com>
Date:   Tue, 26 Nov 2019 14:27:35 +0530
From:   Anshuman Khandual <anshuman.khandual@....com>
To:     Yang Shi <yang.shi@...ux.alibaba.com>, songliubraving@...com,
        kirill.shutemov@...ux.intel.com, akpm@...ux-foundation.org
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: khugepaged: add trace status description for
 SCAN_PAGE_HAS_PRIVATE



On 11/25/2019 11:57 PM, Yang Shi wrote:
> The commit 99cb0dbd47a15d395bf3faa78dc122bc5efe3fc0 ("mm,thp: add

Reduce the commit SHA ID here to just 12 digits instead ?

> read-only THP support for (non-shmem) FS") instroduced a new khugepaged

s/instroduced/introduced/

> scan result: SCAN_PAGE_HAS_PRIVATE, but the corresponding description
> for trance events were not added.

s/trance/trace/

> 
> Cc: Song Liu <songliubraving@...com>
> Cc: Kirill A. Shutemov <kirill.shutemov@...ux.intel.com>
> Signed-off-by: Yang Shi <yang.shi@...ux.alibaba.com>
> ---
>  include/trace/events/huge_memory.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/include/trace/events/huge_memory.h b/include/trace/events/huge_memory.h
> index dd4db33..d49fbce 100644
> --- a/include/trace/events/huge_memory.h
> +++ b/include/trace/events/huge_memory.h
> @@ -31,7 +31,8 @@
>  	EM( SCAN_ALLOC_HUGE_PAGE_FAIL,	"alloc_huge_page_failed")	\
>  	EM( SCAN_CGROUP_CHARGE_FAIL,	"ccgroup_charge_failed")	\
>  	EM( SCAN_EXCEED_SWAP_PTE,	"exceed_swap_pte")		\
> -	EMe(SCAN_TRUNCATED,		"truncated")			\
> +	EM( SCAN_TRUNCATED,		"truncated")			\
> +	EMe(SCAN_PAGE_HAS_PRIVATE,	"has_private")			\

Majority of the SCAN_PAGE_* scan results have page_ in the front. Hence we
should just follow same pattern here and make it 'page_has_private' instead.

>  
>  #undef EM
>  #undef EMe
>