linux-kernel - Re: [PATCH] mm: use the existing variable instead of a duplicate statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bbc278b2-d897-5a43-befd-7be8dacd8495@redhat.com>
Date:   Tue, 26 Nov 2019 13:13:48 +0100
From:   David Hildenbrand <david@...hat.com>
To:     Hao Lee <haolee.swjtu@...il.com>, akpm@...ux-foundation.org
Cc:     mgorman@...e.de, linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: use the existing variable instead of a duplicate
 statement

On 25.11.19 15:53, Hao Lee wrote:
> The address of zone has been stored in variable 'zone', so there is no need
> to get it again with a duplicate statement.
> 
> Signed-off-by: Hao Lee <haolee.swjtu@...il.com>
> ---
>  mm/vmscan.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index ee4eecc7e1c2..de4b2d1e66be 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -363,22 +363,21 @@ unsigned long lruvec_lru_size(struct lruvec *lruvec, enum lru_list lru, int zone
>  	for (zid = zone_idx + 1; zid < MAX_NR_ZONES; zid++) {
>  		struct zone *zone = &lruvec_pgdat(lruvec)->node_zones[zid];
>  		unsigned long size;
>  
>  		if (!managed_zone(zone))
>  			continue;
>  
>  		if (!mem_cgroup_disabled())
>  			size = mem_cgroup_get_zone_lru_size(lruvec, lru, zid);
>  		else
> -			size = zone_page_state(&lruvec_pgdat(lruvec)->node_zones[zid],
> -				       NR_ZONE_LRU_BASE + lru);
> +			size = zone_page_state(zone, NR_ZONE_LRU_BASE + lru);
>  		lru_size -= min(size, lru_size);
>  	}
>  
>  	return lru_size;
>  
>  }
>  
>  /*
>   * Add a shrinker callback to be called from the vm.
>   */
> 

Maybe tweak the subject to something meaningful:

"mm/vmscan: reuse stored zone in lruvec_lru_size()"

Reviewed-by: David Hildenbrand <david@...hat.com>

-- 
Thanks,

David / dhildenb