linux-kernel - Re: [PATCH] mm: fix comments related to node reclaim

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+PpKPkecQmqZya_iHP9bMvfrz-mYEP0bazAtWj1YbE-uTfCOg@mail.gmail.com>
Date:   Tue, 26 Nov 2019 22:09:43 +0800
From:   Hao Lee <haolee.swjtu@...il.com>
To:     Anshuman Khandual <anshuman.khandual@....com>
Cc:     akpm@...ux-foundation.org, mgorman@...hsingularity.net,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: fix comments related to node reclaim

On Tue, 26 Nov 2019 at 17:42, Anshuman Khandual
<anshuman.khandual@....com> wrote:
> On 11/25/2019 07:50 PM, Hao Lee wrote:
> > --- a/include/uapi/linux/capability.h
> > +++ b/include/uapi/linux/capability.h
> > @@ -273,7 +273,7 @@ struct vfs_ns_cap_data {
> >  /* Allow enabling/disabling tagged queuing on SCSI controllers and sending
> >     arbitrary SCSI commands */
> >  /* Allow setting encryption key on loopback filesystem */
> > -/* Allow setting zone reclaim policy */
> > +/* Allow setting node reclaim policy */
>
> Does this point to the capability for accessing vm.zone_reclaim_mode = 0
> sysctl knob ? In that case we should not be changing the name here as the
> interface still retains the original name 'zone_reclaim_mode'.

Yes. This comment should be consistent with sysctl documentation and
interface. Thanks for your correction!