linux-kernel - Re: [PATCH v6 1/2] perf: support multiple debug options separated by ','

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191126141820.kodiejolpyxwz5ck@mail.google.com>
Date:   Tue, 26 Nov 2019 22:18:22 +0800
From:   Changbin Du <changbin.du@...il.com>
To:     Ravi Bangoria <ravi.bangoria@...ux.ibm.com>
Cc:     Changbin Du <changbin.du@...il.com>, Jiri Olsa <jolsa@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Namhyung Kim <namhyung@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 1/2] perf: support multiple debug options separated by
 ','

On Tue, Nov 26, 2019 at 11:10:45AM +0530, Ravi Bangoria wrote:
> 
> 
> On 11/25/19 8:44 PM, Changbin Du wrote:
> >   	List of debug variables allowed to set:
> > -	  verbose          - general debug messages
> > -	  ordered-events   - ordered events object debug messages
> > -	  data-convert     - data convert command debug messages
> > -	  stderr           - write debug output (option -v) to stderr
> > -	                     in browser mode
> > -	  perf-event-open  - Print perf_event_open() arguments and
> > -			     return value
> > +	  verbose=level		- general debug messages
> > +	  ordered-events=level	- ordered events object debug messages
> > +	  data-convert=level	- data convert command debug messages
> > +	  stderr		- write debug output (option -v) to stderr
> > +	  perf-event-open	- Print perf_event_open() arguments and
> > +	                          return value in browser mode
> Shouldn't this be:
> 
> 	  stderr		- write debug output (option -v) to stderr
> 	  			  in browser mode
> 	  perf-event-open	- Print perf_event_open() arguments and
> 	                          return value
> 
This is an accident when rebasing. Thank you.

> -Ravi
> 

-- 
Cheers,
Changbin Du