linux-kernel - Re: [PATCH] usb: typec: fix use after free in typec_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191126154654.GA6428@kuha.fi.intel.com>
Date:   Tue, 26 Nov 2019 17:46:54 +0200
From:   Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To:     Wen Yang <wenyang@...ux.alibaba.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: typec: fix use after free in typec_register_port()

On Tue, Nov 26, 2019 at 10:04:52PM +0800, Wen Yang wrote:
> We can't use "port->sw" and/or "port->mux" after it has been freed.
> 
> Fixes: 23481121c81d ("usb: typec: class: Don't use port parent for getting mux handles")
> Signed-off-by: Wen Yang <wenyang@...ux.alibaba.com>
> Cc: Heikki Krogerus <heikki.krogerus@...ux.intel.com>

Acked-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>

> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: linux-usb@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> ---
>  drivers/usb/typec/class.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c
> index 7ece6ca..91d6227 100644
> --- a/drivers/usb/typec/class.c
> +++ b/drivers/usb/typec/class.c
> @@ -1612,14 +1612,16 @@ struct typec_port *typec_register_port(struct device *parent,
>  
>  	port->sw = typec_switch_get(&port->dev);
>  	if (IS_ERR(port->sw)) {
> +		ret = PTR_ERR(port->sw);
>  		put_device(&port->dev);
> -		return ERR_CAST(port->sw);
> +		return ERR_PTR(ret);
>  	}
>  
>  	port->mux = typec_mux_get(&port->dev, NULL);
>  	if (IS_ERR(port->mux)) {
> +		ret = PTR_ERR(port->mux);
>  		put_device(&port->dev);
> -		return ERR_CAST(port->mux);
> +		return ERR_PTR(ret);
>  	}
>  
>  	ret = device_add(&port->dev);
> -- 
> 1.8.3.1

thanks,

-- 
heikki