linux-kernel - Re: [PATCH] usb: roles: fix a potential use after free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191126155059.GC6428@kuha.fi.intel.com>
Date:   Tue, 26 Nov 2019 17:50:59 +0200
From:   Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To:     Wen Yang <wenyang@...ux.alibaba.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Hans de Goede <hdegoede@...hat.com>,
        Chunfeng Yun <chunfeng.yun@...iatek.com>,
        Suzuki K Poulose <suzuki.poulose@....com>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: roles: fix a potential use after free

On Tue, Nov 26, 2019 at 05:49:17PM +0200, Heikki Krogerus wrote:
> On Sun, Nov 24, 2019 at 10:22:36PM +0800, Wen Yang wrote:
> > Free the sw structure only after we are done using it.
> > This patch just moves the put_device() down a bit to avoid the
> > use after free.
> > 
> > Fixes: 5c54fcac9a9d ("usb: roles: Take care of driver module reference counting")
> > Signed-off-by: Wen Yang <wenyang@...ux.alibaba.com>
> > Cc: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
> > Cc: Hans de Goede <hdegoede@...hat.com>
> > Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > Cc: Chunfeng Yun <chunfeng.yun@...iatek.com>
> > Cc: Suzuki K Poulose <suzuki.poulose@....com>
> > Cc: linux-usb@...r.kernel.org
> > Cc: linux-kernel@...r.kernel.org

Ups, sorry. I meant:

Reviewed-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>

thanks,

-- 
heikki