linux-kernel - Re: [PATCH 0/2] btrfs qgroup cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191126170011.GN2734@twin.jikos.cz>
Date:   Tue, 26 Nov 2019 18:00:12 +0100
From:   David Sterba <dsterba@...e.cz>
To:     Marcos Paulo de Souza <marcos.souza.org@...il.com>
Cc:     linux-kernel@...r.kernel.org, dsterba@...e.com,
        linux-btrfs@...r.kernel.org, anand.jain@...cle.com,
        Marcos Paulo de Souza <mpdesouza@...e.com>
Subject: Re: [PATCH 0/2] btrfs qgroup cleanup

On Mon, Nov 25, 2019 at 09:58:49PM -0300, Marcos Paulo de Souza wrote:
> From: Marcos Paulo de Souza <mpdesouza@...e.com>
> 
> While reading the qgroup code and doing some tests, I found some two things
> that I would like to change:
> * Remove some useless code that was being set only to check if
>   fs_info->quota_root was not NULL
> * Check why creating a qgroup was returning EINVAL
> 
> The answer to the second point was: EINVAL is returned when a user tries to
> create/delete/list/assign a qgroup to a subvolume, but this subvolume does
> not have quota enabled. Talking with David, he suggested to change it to
> ENOTCONN, following what is currently being used in balance and scrub.
> 
> So here are the changes. Please take a look!

Added to misc-next with minor subject edits, thanks.