linux-kernel - Re: [PATCH v2] of: unittest: fix memory leak in attach_node_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191126192337.GA13881@bogus>
Date:   Tue, 26 Nov 2019 12:23:37 -0700
From:   Rob Herring <robh@...nel.org>
To:     Erhard Furtner <erhard_f@...lbox.org>
Cc:     linuxppc-dev@...abs.org, robh+dt@...nel.org,
        frowand.list@...il.com, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Erhard Furtner <erhard_f@...lbox.org>,
        Michael Ellerman <mpe@...erman.id.au>,
        Tyrel Datwyler <tyreld@...ux.ibm.com>
Subject: Re: [PATCH v2] of: unittest: fix memory leak in
 attach_node_and_children

On Tue, 26 Nov 2019 02:48:04 +0100, Erhard Furtner wrote:
> In attach_node_and_children memory is allocated for full_name via
> kasprintf. If the condition of the 1st if is not met the function
> returns early without freeing the memory. Add a kfree() to fix that.
> 
> This has been detected with kmemleak:
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=205327
> 
> It looks like the leak was introduced by this commit:
> Fixes: 5babefb7f7ab ("of: unittest: allow base devicetree to have symbol metadata")
> 
> Signed-off-by: Erhard Furtner <erhard_f@...lbox.org>
> Reviewed-by: Michael Ellerman <mpe@...erman.id.au>
> Reviewed-by: Tyrel Datwyler <tyreld@...ux.ibm.com>
> ---
> Changes in v2:
>   - Make the commit message more clearer.
> 
>  drivers/of/unittest.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 

Applied, thanks.

Rob