linux-kernel - RE: [PATCH] Input: snvs_pwrkey - remove gratuitous NULL initializers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 26 Nov 2019 00:40:54 +0000
From:   Anson Huang <anson.huang@....com>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>
CC:     Robin van der Gracht <robin@...tonic.nl>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] Input: snvs_pwrkey - remove gratuitous NULL initializers



> Subject: [PATCH] Input: snvs_pwrkey - remove gratuitous NULL initializers
> 
> Gratuitous NULL initializers rarely help and often prevent compiler from
> warning about using uninitialized variable. Let's remove them.
> 
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>

Reviewed-by: Anson Huang <Anson.Huang@....com>

> ---
>  drivers/input/keyboard/snvs_pwrkey.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/input/keyboard/snvs_pwrkey.c
> b/drivers/input/keyboard/snvs_pwrkey.c
> index fd6f244f403d..2f5e3ab5ed63 100644
> --- a/drivers/input/keyboard/snvs_pwrkey.c
> +++ b/drivers/input/keyboard/snvs_pwrkey.c
> @@ -108,8 +108,8 @@ static void imx_snvs_pwrkey_act(void *pdata)
> 
>  static int imx_snvs_pwrkey_probe(struct platform_device *pdev)  {
> -	struct pwrkey_drv_data *pdata = NULL;
> -	struct input_dev *input = NULL;
> +	struct pwrkey_drv_data *pdata;
> +	struct input_dev *input;
>  	struct device_node *np;
>  	int error;
>  	u32 vid;
> --
> 2.24.0.432.g9d3f5f5b63-goog
> 
> 
> --
> Dmitry