linux-kernel - Re: [PATCH 4/8] rtc: ds1685: fix build error with make W=1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191126211629.GP299836@piout.net>
Date:   Tue, 26 Nov 2019 22:16:29 +0100
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     Joshua Kinard <kumba@...too.org>
Cc:     linux-rtc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/8] rtc: ds1685: fix build error with make W=1

On 23/11/2019 00:19:45-0500, Joshua Kinard wrote:
> On 11/22/2019 05:22, Alexandre Belloni wrote:
> > Fix the following parsing errors when building with W=1:
> > drivers/rtc/rtc-ds1685.c:1053: error: Cannot parse struct or union!
> > drivers/rtc/rtc-ds1685.c:1062: error: Cannot parse struct or union!
> > drivers/rtc/rtc-ds1685.c:1363: warning: cannot understand function prototype: 'struct platform_driver ds1685_rtc_driver = '
> > 
> > Cc: Joshua Kinard <kumba@...too.org>
> > Signed-off-by: Alexandre Belloni <alexandre.belloni@...tlin.com>
> > ---
> >  drivers/rtc/rtc-ds1685.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/rtc/rtc-ds1685.c b/drivers/rtc/rtc-ds1685.c
> > index 8419595e7da7..56c670af2e50 100644
> > --- a/drivers/rtc/rtc-ds1685.c
> > +++ b/drivers/rtc/rtc-ds1685.c
> > @@ -1039,7 +1039,7 @@ ds1685_rtc_sysfs_serial_show(struct device *dev,
> >  }
> >  static DEVICE_ATTR(serial, S_IRUGO, ds1685_rtc_sysfs_serial_show, NULL);
> >  
> > -/**
> > +/*
> >   * struct ds1685_rtc_sysfs_misc_attrs - list for misc RTC features.
> >   */
> >  static struct attribute*
> > @@ -1050,7 +1050,7 @@ ds1685_rtc_sysfs_misc_attrs[] = {
> >  	NULL,
> >  };
> >  
> > -/**
> > +/*
> >   * struct ds1685_rtc_sysfs_misc_grp - attr group for misc RTC features.
> >   */
> >  static const struct attribute_group
> > @@ -1355,7 +1355,7 @@ ds1685_rtc_remove(struct platform_device *pdev)
> >  	return 0;
> >  }
> >  
> > -/**
> > +/*
> >   * ds1685_rtc_driver - rtc driver properties.
> >   */
> >  static struct platform_driver ds1685_rtc_driver = {
> > 
> 
> /** is for kerneldoc comments.  Is this a bug in kbuild's W=1 implementation
> of not parsing kerneldoc on a struct correctly?  I'm sure I got that syntax
> for structs out of the kerneldoc guide, unless it changed at some point.
> 

I would think it is gcc that is choking on that, probably because the
members are not described.


-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com