linux-kernel - Re: [PATCH v2] crypto: caam - do not reset pointer size from MCFGR register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <VI1PR04MB4445DBB28CDB92553B5BDB8C8C450@VI1PR04MB4445.eurprd04.prod.outlook.com>
Date:   Tue, 26 Nov 2019 22:25:38 +0000
From:   Iuliana Prodan <iuliana.prodan@....com>
To:     Horia Geanta <horia.geanta@....com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Aymen Sghaier <aymen.sghaier@....com>
CC:     "David S. Miller" <davem@...emloft.net>,
        Andrey Smirnov <andrew.smirnov@...il.com>,
        Alison Wang <alison.wang@....com>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>
Subject: Re: [PATCH v2] crypto: caam - do not reset pointer size from MCFGR
 register

On 11/26/2019 7:03 PM, Horia Geanta wrote:
> On 11/26/2019 2:23 PM, Iuliana Prodan wrote:
>> In commit 'a1cf573ee95 ("crypto: caam - select DMA address
>> size at runtime")' CAAM pointer size (caam_ptr_size) is changed
> When quoting a commit, it shouldn't be split across several lines.
> 
Right, I'll send a v3.

>> from sizeof(dma_addr_t) to runtime value computed from MCFGR register.
>> Therefore, do not reset MCFGR[PS].
>>
>> Fixes: a1cf573ee95 ("crypto: caam - select DMA address size at runtime")
>> Signed-off-by: Iuliana Prodan <iuliana.prodan@....com>
>> Cc: <stable@...r.kernel.org>
>> Cc: Andrey Smirnov <andrew.smirnov@...il.com>
>> Cc: Alison Wang <alison.wang@....com>
> Reviewed-by: Horia Geantă <horia.geanta@....com>
> 
Thanks,
Iulia