linux-kernel - [PATCH 0/2] btrfs qgroup cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20191126005851.11813-1-marcos.souza.org@gmail.com>
Date:   Mon, 25 Nov 2019 21:58:49 -0300
From:   Marcos Paulo de Souza <marcos.souza.org@...il.com>
To:     linux-kernel@...r.kernel.org
Cc:     dsterba@...e.com, linux-btrfs@...r.kernel.org,
        anand.jain@...cle.com, Marcos Paulo de Souza <mpdesouza@...e.com>
Subject: [PATCH 0/2] btrfs qgroup cleanup

From: Marcos Paulo de Souza <mpdesouza@...e.com>

While reading the qgroup code and doing some tests, I found some two things
that I would like to change:
* Remove some useless code that was being set only to check if
  fs_info->quota_root was not NULL
* Check why creating a qgroup was returning EINVAL

The answer to the second point was: EINVAL is returned when a user tries to
create/delete/list/assign a qgroup to a subvolume, but this subvolume does
not have quota enabled. Talking with David, he suggested to change it to
ENOTCONN, following what is currently being used in balance and scrub.

So here are the changes. Please take a look!

Marcos Paulo de Souza (2):
  btrfs: qgroup: Cleanup quota_root checks
  btrfs: qgroup: Return -ENOTCONN instead of -EINVAL

 fs/btrfs/qgroup.c | 44 +++++++++++++++-----------------------------
 1 file changed, 15 insertions(+), 29 deletions(-)

-- 
2.23.0