linux-kernel - Re: [PATCH -v5 00/17] Rewrite x86/ftrace to use text

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 26 Nov 2019 20:32:29 -0800
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Masami Hiramatsu <mhiramat@...nel.org>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        Ard Biesheuvel <ard.biesheuvel@...aro.org>,
        bristot <bristot@...hat.com>, "H. Peter Anvin" <hpa@...or.com>,
        jbaron@...mai.com, Jessica Yu <jeyu@...nel.org>,
        Josh Poimboeuf <jpoimboe@...hat.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Andy Lutomirski <luto@...nel.org>,
        Ingo Molnar <mingo@...nel.org>, Nadav Amit <namit@...are.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        X86 ML <x86@...nel.org>
Subject: Re: [PATCH -v5 00/17] Rewrite x86/ftrace to use text_poke (and more)

On Tue, Nov 26, 2019 at 4:03 PM Alexei Starovoitov
<alexei.starovoitov@...il.com> wrote:
>
>
>
> On Tue, Nov 26, 2019 at 3:49 PM Masami Hiramatsu <mhiramat@...nel.org> wrote:
>>
>> On Tue, 26 Nov 2019 18:58:09 +0900
>> Masami Hiramatsu <mhiramat@...nel.org> wrote:
>> > I applied following patch, but it seems not enough. While disabling 256 kprobes,
>> > system was frozen (no BUG message).
>>
>> Aah, this is another bug in optprobe. I'll send a series for fix these bugs.
>
>
> Awesome! I’ve started looking at this crash as well.
> Could you share a brief description of the bug and cc me on fixes?
> I’d like to test them too.
> Thanks

I noticed that your config doesn't have CONFIG_KPROBES_ON_FTRACE=y
and without it most test.d/kprobe/ tests fail, but in your log they are passing.
Also do you have KPROBE_EVENTS_ON_NOTRACE=y ?
Since without these two configs the crash wasn't reproducing for me.
Anyhow waiting for your fixes.