linux-kernel - Re: [PATCH 1/5] pinctrl: actions: Use the correct style for SPDX License Identifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c76290a7-b9bb-7f70-e750-04fe6fdbb7e1@suse.de>
Date:   Wed, 27 Nov 2019 22:02:08 +0100
From:   Andreas Färber <afaerber@...e.de>
To:     Nishad Kamdar <nishadkamdar@...il.com>,
        Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
Cc:     Sean Wang <sean.wang@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Kevin Hilman <khilman@...libre.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre Torgue <alexandre.torgue@...com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Joe Perches <joe@...ches.com>,
        Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-gpio@...r.kernel.org,
        linux-amlogic@...ts.infradead.org,
        linux-renesas-soc@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/5] pinctrl: actions: Use the correct style for SPDX
 License Identifier

Am 27.11.19 um 17:40 schrieb Nishad Kamdar:
> This patch corrects the SPDX License Identifier style in
> header file related Actions Semi OWL pinctrl driver.

Owl

> For C header files Documentation/process/license-rules.rst
> mandates C-like comments (opposed to C source files where
> C++ style should be used).
> 
> Changes made by using a script provided by Joe Perches here:
> https://lkml.org/lkml/2019/2/7/46.
> 
> Suggested-by: Joe Perches <joe@...ches.com>
> Signed-off-by: Nishad Kamdar <nishadkamdar@...il.com>
> ---
>  drivers/pinctrl/actions/pinctrl-owl.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/actions/pinctrl-owl.h b/drivers/pinctrl/actions/pinctrl-owl.h
> index dae2e8363fd5..feee7ad7e27e 100644
> --- a/drivers/pinctrl/actions/pinctrl-owl.h
> +++ b/drivers/pinctrl/actions/pinctrl-owl.h
> @@ -1,4 +1,4 @@
> -// SPDX-License-Identifier: GPL-2.0+
> +/* SPDX-License-Identifier: GPL-2.0+ */

This is not a uapi or asm header, which that /* */ rule was later added
for, I thought?

>  /*
>   * OWL SoC's Pinctrl definitions
>   *

Not objecting, just making sure we're not blindly refactoring code.

If doing this, I suggest updating to GPL-2.0-or-later.

Regards,
Andreas

-- 
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer
HRB 36809 (AG Nürnberg)