linux-kernel - Re: [PATCH] cpu: microcode: Add comma to 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 27 Nov 2019 07:54:36 +0100
From:   Ingo Molnar <mingo@...nel.org>
To:     Jules Irenge <jbi.octave@...il.com>
Cc:     bp@...en8.de, tglx@...utronix.de, linux-kernel@...r.kernel.org,
        x86@...nel.org, hpa@...or.com, mingo@...hat.com
Subject: Re: [PATCH] cpu: microcode: Add comma to 0


* Jules Irenge <jbi.octave@...il.com> wrote:

> Add ","  after 0
> Because memory for the struct is being cleared
> and elements after "," are missing on purpose
>  as they are being cleared to
> 
> Recommended by Boris Petkov
> 
> Signed-off-by: Jules Irenge <jbi.octave@...il.com>
> ---
>  arch/x86/kernel/cpu/microcode/amd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kernel/cpu/microcode/amd.c b/arch/x86/kernel/cpu/microcode/amd.c
> index a0e52bd00ecc..04ee649f4acb 100644
> --- a/arch/x86/kernel/cpu/microcode/amd.c
> +++ b/arch/x86/kernel/cpu/microcode/amd.c
> @@ -418,7 +418,7 @@ static int __apply_microcode_amd(struct microcode_amd *mc)
>  static bool
>  apply_microcode_early_amd(u32 cpuid_1_eax, void *ucode, size_t size, bool save_patch)
>  {
> -	struct cont_desc desc = { 0 };
> +	struct cont_desc desc = { 0, };

This is 100% unnecessary - " = { }" is enough of a structure initializer.

Thanks,

	Ingo