linux-kernel - Re: [PATCH 2/2] thermal: armada-thermal: clear reset in armadaxp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191127120018.679bf947@xps13>
Date:   Wed, 27 Nov 2019 12:00:18 +0100
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Zak Hays <zak.hays@...mark.com>
Cc:     Zhang Rui <rui.zhang@...el.com>,
        Eduardo Valentin <edubezval@...il.com>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Amit Kucheria <amit.kucheria@...durent.com>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] thermal: armada-thermal: clear reset in
 armadaxp_init

Hi Zak,

Zak Hays <zak.hays@...mark.com> wrote on Tue, 26 Nov 2019 14:54:11
+0000:

> The reset bit needs to be cleared in the init sequence otherwise it
> 
> holds the block in reset.

"thermal: armada: " is the right prefix for your title

Your Signed-off-by should be here (git commit --amend -s)

The format of your patch is strange, there are additional empty lines
which are problematic.

> 
> ---
> 
>  drivers/thermal/armada_thermal.c | 3 +++
> 
>  1 file changed, 3 insertions(+)
> 
> 
> 
> diff --git a/drivers/thermal/armada_thermal.c b/drivers/thermal/armada_thermal.c
> 
> index 88363812033c..8c4d1244ee7a 100644
> 
> --- a/drivers/thermal/armada_thermal.c
> 
> +++ b/drivers/thermal/armada_thermal.c
> 
> @@ -155,6 +155,9 @@ static void armadaxp_init(struct platform_device *pdev,
> 
>  
> 
>          regmap_write(priv->syscon, data->syscon_control1_off, reg);
> 
>  
> 
> +       reg &= ~PMU_TDC0_SW_RST_MASK;
> 
> +       regmap_write(priv->syscon, data->syscon_control1_off, reg);
> 
> +

Do you really want to write this register twice? Shouldn't you get rid
of the first regmap_write() above?

> 
>          /* Enable the sensor */
> 
>          regmap_read(priv->syscon, data->syscon_status_off, &reg);
> 
>          reg &= ~PMU_TM_DISABLE_MASK;
> 

In your next iteration, please use the '-v2' option with
git-format-patch to get titles starting with "[PATCH v2 x/2] ..."
automatically. Also write a changelog below the three dots '---'.

Thanks,
Miquèl