linux-kernel - Re: [PATCH] ALSA: aloop: Avoid pointer dereference before null-check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5h8so1y3gc.wl-tiwai@suse.de>
Date:   Wed, 27 Nov 2019 12:16:19 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     Andrew Gabbasov <andrew_gabbasov@...tor.com>
Cc:     <alsa-devel@...a-project.org>, <linux-kernel@...r.kernel.org>,
        "Jaroslav Kysela" <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
        Eugeniu Rosca <erosca@...adit-jv.com>,
        Timo Wischer <twischer@...adit-jv.com>
Subject: Re: [PATCH] ALSA: aloop: Avoid pointer dereference before null-check

On Wed, 27 Nov 2019 12:06:22 +0100,
Andrew Gabbasov wrote:
> 
> Static analysis tools (cppcheck and PVS Studio) report an error
> in loopback_snd_timer_period_elapsed() regarding dpcm_play pointer
> dereference earlier than its null-check. And although this is a result
> of a formal check, and the pointer correctness is also protected
> by having a corresponding bit set in the "running" mask, re-ordering
> of the lines can imake the code even formally correct and eliminate
> those static analysis error reports.
> 
> Fixes: 26c53379f98d ("ALSA: aloop: Support selection of snd_timer instead of jiffies")
> Reported-by: Eugeniu Rosca <erosca@...adit-jv.com>
> Signed-off-by: Andrew Gabbasov <andrew_gabbasov@...tor.com>

Applied, thanks.


Takashi