linux-kernel - Re: [PATCH] brcmsmac: Remove always false 'channel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0101016ead12c1ea-1f40653d-0ca6-4e03-8b7b-7fceb2ec87bf-000000@us-west-2.amazonses.com>
Date:   Wed, 27 Nov 2019 13:35:18 +0000
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Austin Kim <austindh.kim@...il.com>
Cc:     Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
        arend.vanspriel@...adcom.com, franky.lin@...adcom.com,
        hante.meuleman@...adcom.com, chi-hsien.lin@...ress.com,
        wright.feng@...ress.com, davem@...emloft.net,
        linux-wireless@...r.kernel.org,
        brcm80211-dev-list.pdl@...adcom.com,
        brcm80211-dev-list@...ress.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] brcmsmac: Remove always false 'channel < 0' statement

Austin Kim <austindh.kim@...il.com> writes:

> 2019년 11월 27일 (수) 오후 7:48, Sergei Shtylyov
> <sergei.shtylyov@...entembedded.com>님이 작성:
>>
>> On 27.11.2019 8:43, Austin Kim wrote:
>>
>> > As 'channel' is declared as u16, the following statement is always false.
>> >     channel < 0
>> >
>> > So we can remove unnecessary 'always false' statement.
>>
>>     It's an expression, not a statement.
>>
>
> According to below link, it is okay to use 'statement' in above case.
> https://en.wikipedia.org/wiki/Statement_(computer_science)

I don't have time to start arguing about this, and I'm no C language
lawyer either, but all I say is that I agree with Sergei here.

> Why don't you show your opition about patch rather than commit message?

But this comment is not ok. Patch review (including commit logs) is the
core principle of upstream development so you need to have an open mind
for all comments, even the ones you don't like.

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches